Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to docker images to prevent branches from overwriting Parastell docker images #159

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

bquan0
Copy link
Collaborator

@bquan0 bquan0 commented Sep 19, 2024

Currently, docker_publish.yml pulls and pushes docker images to a hardcoded image name and tag, which is the official parastell docker image. This can be problematic if a branch changes something and pushes a docker image that doesn't work.

I have changed docker_publish.yml to now pull and push docker images to the same image name, but with a tag based on the branch name if the branch is not main. This way, contributors can make changes without worrying about breaking the official image.

This PR is a continuation of #154, with the difference being that this PR was pushed to a branch in the repo owned by svalinn instead of a branch in my forked repo.

@bquan0
Copy link
Collaborator Author

bquan0 commented Sep 19, 2024

The workflows have passed, and there are now new docker-build-tweak tags for the parastell image and the parastell-ci image (since that's the name of this branch). The Test CI Image workflow run also uses the image with the correct tag.

Let me know if I should change the tag name generation.

@bquan0 bquan0 requested a review from gonuke September 19, 2024 23:23
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bquan0

@gonuke gonuke merged commit 3224b20 into main Sep 20, 2024
4 checks passed
@connoramoreno connoramoreno deleted the docker-build-tweak branch September 23, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants