Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build instructions for DAGMC dependencies #963

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gonuke
Copy link
Member

@gonuke gonuke commented Oct 25, 2024

The instructions for building DAGMC were extremely out of date.

This updates them, and we will try to publish new ones.

Copy link
Member

@ahnaf-tahmid-chowdhury ahnaf-tahmid-chowdhury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

Instructions for installing hdf5 in RPM based distro would be:

sudo yum install -y epel-release
sudo yum config-manager --enable epel
sudo yum install hdf5-devel

If Eigen3 is a dependency of DAGMC, we should either create a method to enable it from the DAGMC side or ask users to enable it in MOAB, as MOAB has made Eigen3 an optional dependency. However, MOAB 5.5.1 is good to go.

@@ -128,5 +127,5 @@ If you have installed the dependencies correctly, you are now ready to
`install DAGMC <dagmc.html>`_.

.. _HDF5: http://www.hdfgroup.org/HDF5
.. _MOAB: http://press3.mcs.anl.gov/sigma/moab-library
.. _MOAB: http://bitbucket.org/fathomteam/moab

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. _MOAB: http://bitbucket.org/fathomteam/moab
.. _MOAB: https://sigma.mcs.anl.gov/moab-library/

@@ -20,6 +20,7 @@ Next version
* Streamline dependencies of docker CI images (#951 #952)
* Update github actions to newer versions as necessary (#958)
* CMake error message update (#960)
* Updated documentation to build dependencies ()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Updated documentation to build dependencies ()
* Updated documentation to build dependencies (#963)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants