Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional output during CMake configuration when double down … #962

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

pshriwise
Copy link
Member

Description

Adds some informational messages when double down is enabled in DAGMC for clarity.

Motivation and Context

Motivated by desire for clarity on whether or not double down will be enabled in the DAGMC build.

@gonuke
Copy link
Member

gonuke commented Oct 8, 2024

Does Double Down provide a a config file for CMake to find? or do we use our won FindDOUBLE_DOWN.cmake file? If the latter, it already includes extra output like this.

It's not in the version that @bquan0 is trying to update on conda-forge, but would be part of the next release.

@gonuke
Copy link
Member

gonuke commented Oct 8, 2024

Does Double Down provide a a config file for CMake to find? or do we use our won FindDOUBLE_DOWN.cmake file? If the latter, it already includes extra output like this.

It's not in the version that @bquan0 is trying to update on conda-forge, but would be part of the next release.

Hmmm... but maybe that's not working either....??

@gonuke
Copy link
Member

gonuke commented Oct 8, 2024

It was working - as seen in this build from 3 days ago.

Your change adds more as seen in this build from this PR.

Can't hurt to have additional messages, but there was already this info.

The reason that the conda-forge build isn't seeing it is because this output wasn't in the right version.

@pshriwise
Copy link
Member Author

It was working - as seen in this build from 3 days ago.

Your change adds more as seen in this build from this PR.

Can't hurt to have additional messages, but there was already this info.

The reason that the conda-forge build isn't seeing it is because this output wasn't in the right version.

Agreed, there was some trace that the DOUBLE_DOWN option was respected. I think it's a little more clear now as someone can search for the same option presented in DAGMC's CMakeLists.txt in the output rather than trying to find Found dd (perhaps my fault for an incongruous package name)

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this extra clarity @pshriwise

@gonuke gonuke merged commit 56181be into svalinn:develop Oct 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants