Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get a substring from the minibuffer prompt without text properties. #175

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

vonavi
Copy link
Contributor

@vonavi vonavi commented Nov 29, 2024

Hi!

The minibuffer prompt may have text properties depending on the Emacs modes enabled. So, let us clean up a substring copied from it.

Best regards,
Vladimir.

@svaante
Copy link
Owner

svaante commented Nov 30, 2024

Hey thank you for your contribution!

Have you completed your FSF assignment? If not, I recommend adding the following line at the end of your commit message:

Copyright-paperwork-exempt: yes

I'm curious about the specifics of where this issue was encountered. Would you mind sharing more details?

If you want to do additional contributions to dape, emacs and/or other packages on elpa, I recommend you to do the FSF assignment.

@vonavi
Copy link
Contributor Author

vonavi commented Nov 30, 2024

Hi Daniel!

Thank you for replying quickly, I have updated the commit message. More specifically, I use ws-butler to trim spaces from lines that I edited (it uses metadata to track modified lines). Maybe someone else will be faced with a similar issue, so it is a good practice to clean up metadata if the buffer content is out of our control. I have checked Dape's code and found only one such place.

Best regards,
Vladimir.

@svaante svaante merged commit f523773 into svaante:master Nov 30, 2024
@svaante
Copy link
Owner

svaante commented Nov 30, 2024

Thank you for your contribution! Please consider doing the FSF assignment, if you want to continue contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants