Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emoji :warning: isn't rendered #1061

Closed
suzuki-shunsuke opened this issue Dec 7, 2023 · 3 comments · Fixed by #1062
Closed

Emoji :warning: isn't rendered #1061

suzuki-shunsuke opened this issue Dec 7, 2023 · 3 comments · Fixed by #1062
Labels
bug Something isn't working
Milestone
v4.7.2

Comments

@suzuki-shunsuke
Copy link
Owner

tfcmt version

$ tfcmt -v
tfcmt version 4.7.1 (7f017a9b800b557b508ed8f4820f834f54b1f172)

Environment

  • OS: darwin
  • CPU Architecture: arm64

Overview

The emoji :warning: is rendered.

image

How to reproduce

Delete resources and run tfcmt plan -- terraform plan.

Executed command and output

$ tfcmt plan -- terraform plan

Debug output

No response

Expected behaviour

The emoji :warning: is rendered.

⚠️

Actual behaviour

The emoji :warning: isn't rendered.

Important Factoids

I think this is a bug or change of GFM (GitHub Flavored Markdown).

Reference

No response
@suzuki-shunsuke suzuki-shunsuke added the bug Something isn't working label Dec 7, 2023
@suzuki-shunsuke
Copy link
Owner Author

suzuki-shunsuke commented Dec 7, 2023 •
edited
Loading

⚠️ hello ⚠️

⚠️ hello

⚠️ ⚠️ hello

⚠️ hello ⚠️ world

hello ⚠️

Yo ⚠️ hello ⚠️ world

@suzuki-shunsuke
Copy link
Owner Author

⚠️ hello ⚠️
⚠️ hello
⚠️ ⚠️ hello
⚠️ hello ⚠️ world
hello ⚠️
Yo ⚠️ hello ⚠️ world

@suzuki-shunsuke
Copy link
Owner Author

suzuki-shunsuke commented Dec 7, 2023 •
edited
Loading

Maybe these issues are related.

As a workaround, I'll remove emojis from the end of lines.

Before

### :warning: Resource Deletion will happen :warning:

After

### :warning: Resource Deletion will happen

suzuki-shunsuke added a commit that referenced this issue Dec 7, 2023
@suzuki-shunsuke
fix: remove emojis from the end of lines
663105c 
- #1061 (comment)
@suzuki-shunsuke suzuki-shunsuke mentioned this issue Dec 7, 2023
Merged
suzuki-shunsuke added a commit that referenced this issue Dec 7, 2023
@suzuki-shunsuke
fix: remove emojis from the end of lines (#1062)
f62005a 
- #1061 (comment)
@suzuki-shunsuke suzuki-shunsuke added this to the v4.7.2 milestone Dec 8, 2023
@suzuki-shunsuke suzuki-shunsuke linked a pull request Dec 8, 2023 that will close this issue
fix: remove emojis from the end of lines #1062
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v4.7.2
Development

Successfully merging a pull request may close this issue.

fix: remove emojis from the end of lines suzuki-shunsuke/tfcmt
1 participant
@suzuki-shunsuke