Feature Request: Output when an imported resource is also changed in the same plan

[DylanRodgers98]

Feature Overview

Currently imports are only output if there are no subsequent changes to them. If an import is changed within the same plan they are output as updates.

For example, with a plan like:

  # resource.default will be updated in-place
  # (imported from "my_resource")
  ~ resource "resource" "default" {
        id = "my_resource"
      - labels = {}
    }

Plan: 1 to import, 0 to add, 1 to change, 0 to destroy.

The following is output by tfcmt:

* Update
  * resource.default

This feature would include the resource in the list of imports:

* Import
  * resource.default
* Update
  * resource.default

Why is the feature needed?

It would be very useful to see if an imported resource is changed within the same plan.

Does the feature include Breaking Changes?

Not as far as I'm aware.

Example Code

No response

Reference

No response

[suzuki-shunsuke]

Thank you for your feedback!

I'll take a look.

tfcmt/pkg/terraform/parser.go

Line 73 in 912cb43

Import: regexp.MustCompile(`^ *# (.*?) will be imported$`),

tfcmt/pkg/terraform/parser.go

Lines 176 to 177 in 912cb43

	} else if rsc := extractResource(p.Import, line); rsc != "" {
	importedResources = append(importedResources, rsc)

[suzuki-shunsuke]

moved block has also the same issue.

  # github_repository.tfaction-2 will be updated in-place
  # (moved from github_repository.tfaction)

[suzuki-shunsuke]

replace should also be supported.

  # github_issue.test-2 must be replaced
  # (moved from github_issue.test)

[suzuki-shunsuke]

There are several options.

1. Add Import

* Import
  * resource.default
* Update
  * resource.default

2. Add (imported from ~) to Update

* Update
  * resource.default (imported from "my_resource")

3. Both

* Import
  * resource.default
* Update
  * resource.default (imported from "my_resource")

[suzuki-shunsuke]

I'll adopt 1 for now.

• The implementation is simple
• For 2 and 3, we need to take into account the compatibility of template variables

[suzuki-shunsuke]

• feat: listing imported or moved resources even if they are changed or replaced #932

[DylanRodgers98]

Nice, thank you for implementing this!

[suzuki-shunsuke]

tfcmt v4.6.0 is out 🚀
https://github.com/suzuki-shunsuke/tfcmt/releases/tag/v4.6.0