Skip to content

Commit

Permalink
fix(mask): change the default separator from ; to ,
Browse files Browse the repository at this point in the history
`;` has a special meaning in shell script.

For example, the following command doesn't work as expected.

```sh
export TFCMT_MASKS=env:GITHUB_TOKEN;env:DATADOG_API_KEY
```

To prevent the bug, I change the separator.
  • Loading branch information
suzuki-shunsuke committed Jan 26, 2024
1 parent dcbce63 commit 56dfca4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/mask/parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func ParseMasks(maskStr, maskSep string) ([]*config.Mask, error) {
return nil, nil
}
if maskSep == "" {
maskSep = ";" // default separator
maskSep = "," // default separator
}
maskStrs := strings.Split(maskStr, maskSep)
masks := make([]*config.Mask, 0, len(maskStrs))
Expand Down

0 comments on commit 56dfca4

Please sign in to comment.