Merge pull request #77 from suzuki-shunsuke/fix/fix-pahse-status-when…

…-skipped

fix: fix the status of skipped phase

examples/main_test.go

@@ -52,6 +52,10 @@ func TestBuildflow(t *testing.T) { //nolint:funlen
 			title: "dynamic task by items",
 			file:  "dynamic_task.yaml",
 		},
+		{
+			title: "skip a phase",
+			file:  "skip_phase.yaml",
+		},
 		{
 			title: "buildflow run fails as expected",
 			file:  "fail.yaml",

examples/skip_phase.yaml

@@ -0,0 +1,9 @@
+---
+phases:
+- name: skipped
+  tasks:
+  - name: hello
+    command:
+      command: echo hello
+  condition:
+    skip: true

pkg/controller/controller.go

@@ -330,7 +330,7 @@ func (ctrl Controller) runPhase(ctx context.Context, params Params, idx int, wd
 	params.Phases[params.PhaseName] = phase
 
 	if p, f := ctrl.checkSkipPhase(params, phase, phaseCfg); f {
-		return phase, nil
+		return p, nil
 	} else {
 		phase = p
 	}
@@ -509,8 +509,8 @@ func (ctrl Controller) Run(ctx context.Context, wd string) error {
 		if phase.Error != nil {
 			phase.Status = constant.Failed
 		}
-		phase.outputResult(ctrl.Stderr, phaseCfg.Name)
 		params.Phases[phaseCfg.Name] = phase
+		phase.outputResult(ctrl.Stderr, phaseCfg.Name)
 		if err != nil {
 			return err
 		}

pkg/controller/phase.go

@@ -109,6 +109,9 @@ func (phase Phase) outputResult(stderr io.Writer, name string) {
 	if phase.Error != nil {
 		fmt.Fprintln(stderr, "error:", phase.Error)
 	}
+	if phase.Status == constant.Skipped {
+		return
+	}
 	utc := locale.UTC()
 	runTasks := []Task{}
 	for _, task := range phase.Tasks.GetAll() {