Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rewritten Prototype] Implement SQ Item parsing #73

Merged
merged 2 commits into from
May 3, 2020

Conversation

suyashkumar
Copy link
Owner

@suyashkumar suyashkumar commented May 3, 2020

This change implements correct parsing of sequence elements. More details on the structure of nested items can be found at the standard here.

Previously, the complete SQ items were read, but not parsed correctly into sequence items.

This change also added support for additional integer VR parsing.

@suyashkumar suyashkumar added the 1.0-rewrite 1.0 Rewrite associated work label May 3, 2020
@suyashkumar suyashkumar self-assigned this May 3, 2020
@suyashkumar suyashkumar merged commit b8ac62c into s/1.0-rewrite May 3, 2020
suyashkumar added a commit that referenced this pull request Jul 19, 2020
This change implements correct parsing of sequence elements. More details on the structure of nested items can be found at the standard here.

Previously, the complete SQ items were read, but not parsed correctly into sequence items.

This change also added support for additional integer VR parsing.
suyashkumar added a commit that referenced this pull request Sep 17, 2020
This change implements correct parsing of sequence elements. More details on the structure of nested items can be found at the standard here.

Previously, the complete SQ items were read, but not parsed correctly into sequence items.

This change also added support for additional integer VR parsing.
suyashkumar added a commit that referenced this pull request Nov 2, 2020
This change implements correct parsing of sequence elements. More details on the structure of nested items can be found at the standard here.

Previously, the complete SQ items were read, but not parsed correctly into sequence items.

This change also added support for additional integer VR parsing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0-rewrite 1.0 Rewrite associated work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant