Handle unknowns completely #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suggestion: this PR may read cleaner if you branch off of the existing changes branch and add on top as needed. I'm not sure if this PR needs the changes from your other PR #233, but if not then that will probably be the cleanest way to setup and review the salient changes in this PR (and make it less likely to be stale as changes are made in the other PRs etc)! You can also probably rebase your new branch to incoporate the changes already merged into main (or if needed I can rebase s/read-un-as-sq). |
|
I'll close this PR now that #235 is up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines this existing branch with the updates made here.
Hopefully this comprehensively handles unknown DICOM elements.
(Note: this PR also contains the changes from my PR currently up)