Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests allowing removal of stretchr/testify test dependency #175

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

suyashkumar
Copy link
Owner

@suyashkumar suyashkumar commented Jan 4, 2021

This change refactors a test to remove the final testify test dependency (all other tests already adopt the convention to not use an assertion library. More about some thinking on why here.

@suyashkumar suyashkumar added enhancement New feature or request cleanup labels Jan 4, 2021
@suyashkumar suyashkumar self-assigned this Jan 4, 2021
@suyashkumar suyashkumar changed the title Refactor and remove testify test dependency Update tests and remove testify test dependency Jan 4, 2021
@suyashkumar suyashkumar changed the title Update tests and remove testify test dependency Update tests and remove stretchr/testify test dependency Jan 4, 2021
@suyashkumar suyashkumar changed the title Update tests and remove stretchr/testify test dependency Update tests allowing removal of stretchr/testify test dependency Jan 4, 2021
@suyashkumar suyashkumar merged commit 69adfab into main Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant