Updates to work with 221.* and convert gradle scripts to kts #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@suusan2go Any chance that this can be merged? |
|
@JohNan thank you for the contribution and sorry for the late reply! Can you create separate PRs for these?
|
suusan2go
reviewed
May 2, 2022
| token.set(System.getenv("TOKEN")) | ||
| channels.set(listOf(properties("pluginVersion").split('-').getOrElse(1) { "default" }.split('.').first())) | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not opposed to adding these things, but can you make PRs into two or three separated PRs?
- just converting Kotlin DSL
- other improvements (change note, description). To be honest, generating change note from the
changelog.mdlooks useful, but I'm not that interested in generating descriptions from README.
|
Sure! The most important thing was to fix the compatibility. I'll make PR's for the other things as soon as I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #59