Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run all tests in CI #319

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

sthaha
Copy link
Collaborator

@sthaha sthaha commented Dec 4, 2023

This PR includes the following fixed

  • run all tests instead of just the reconciliation test
  • provide more time for operator to be ready before running tests
  • fix the broken invalid resource name that used wrong namespace for kepler deployment

Signed-off-by: Sunil Thaha <[email protected]>
This commit increases the liveness and the readiness probes' timeout so
that the operator has time to build its internal cache and be ready
for reconcile.

Tests fail because the resources (kepler) are recreated and expected to
be reconciled before the operator has had a change to build cache and
the informers.

Signed-off-by: Sunil Thaha <[email protected]>
Copy link
Collaborator

@vprashar2929 vprashar2929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vprashar2929 vprashar2929 merged commit 8af3e27 into sustainable-computing-io:v1alpha1 Dec 4, 2023
9 checks passed
@sthaha sthaha deleted the fix-ci-test branch December 4, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants