Feat: export correct namespace #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(which is the same as container_namespace) applied after scraping Signed-off-by: Bastien Grasnick <[email protected]>
…nitoring Signed-off-by: Bastien Grasnick <[email protected]>
sthaha
reviewed
Nov 20, 2023
BGrasnick
force-pushed
the
feat/302-export-correct-namespace-and-make-metrics-available-to-cluster-monitoring
branch
from
b430c78 to
49559f5
Compare
…kload monitoring" This reverts commit 1e395b7. Signed-off-by: Bastien Grasnick <[email protected]>
BGrasnick
force-pushed
the
feat/302-export-correct-namespace-and-make-metrics-available-to-cluster-monitoring
branch
from
49559f5 to
b82f99e
Compare
BGrasnick
changed the title
sthaha
reviewed
Nov 20, 2023
Comment on lines
+492
to
+499
| metricRelabelings := []*monv1.RelabelConfig{{ | ||
| Action: "replace", | ||
| SourceLabels: []monv1.LabelName{ | ||
| "container_namespace", | ||
| }, | ||
| TargetLabel: "namespace", | ||
| }} | ||
|
|
There was a problem hiding this comment.
@BGrasnick Have you tested this on OpenShift? IIUC, this will not be honoured in openshift if you use User Project Monitoring.
|
@BGrasnick I am going to close this due to the reason mentioned above. Please feel free to reopen if you have found a solution for this. Meanwhile we have added the dashboards to developer view as well. So any user with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the ServiceMonitor relabel namespace to have the same value as container_namespace instead of "openshift-kepler-operator" applied after scraping so that it is more straight-forward to use the metrics.
Also adds label
"openshift.io/cluster-monitoring": "true"so that the metrics get scraped by openshift-monitoring instead of user workload monitoring which makes usage more straight-forward.I am not sure if this is wanted for kepler-operator but in our use case it would be much better. In case this is not the intended behaviour, we can just revert the corresponding commit.
Was tested and works on OpenShift 4.11 cluster.
Addresses #302