Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment with Rancher Turtles #368

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

hardys
Copy link
Contributor

@hardys hardys commented Sep 11, 2024

This aligns with the recently added suse-edge charts which enable management of CAPI dependencies via Rancher Turtles

Depends On:
suse-edge/charts#150 (merged) and suse-edge/charts#154

@hardys
Copy link
Contributor Author

hardys commented Sep 11, 2024

Also see suse-edge/atip#7

Copy link
Contributor

@alknopfler alknopfler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Steven

@hardys
Copy link
Contributor Author

hardys commented Sep 12, 2024

One thing to note is this currently refers to charts we've not yet published via registry.suse.com - I think we'll have that issue in other places, but if preferred I can update this to reference the suse-edge/charts upstream charts instead as a temporary measure

@hardys hardys marked this pull request as draft September 12, 2024 10:44
@hardys hardys marked this pull request as ready for review September 26, 2024 10:21
This aligns with the recently added suse-edge charts which enable
management of CAPI dependencies via Rancher Turtles
Copy link
Contributor

@Kristian-ZH Kristian-ZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hardys hardys merged commit 8c08e82 into suse-edge:main Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants