Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update images and chart of SRIOV #108

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

manuelbuil
Copy link
Collaborator

@manuelbuil manuelbuil commented Mar 27, 2024

This PR does a sweeping version bump in all the SRIOV related projects:

  • Moves the chart to "latest". Unfortunately, there has not been an official release since July 2022, so we need to use the commit. We bumped the version almost 2 years and we are pointing now at the latest commit
  • operator, sriovConfigDaemon move to v1.2.0-build20240327
  • sriovCni moves to v2.7.0-build20240327
  • ibSriovCni moves to v1.0.3-build20240327
  • sriovDevicePlugin moves to v3.6.2-build20240327
  • resourcesInjector moves to v1.5-build20240327

We would be using more up to date code and images, which provides important benefits such as reducing CVEs to 0

We are creating new charts/assets with version v1.2.0

Copy link
Contributor

@Kristian-ZH Kristian-ZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Let's wait for one more approval before merging the PR

@manuelbuil
Copy link
Collaborator Author

We are going to do an extra update to remove all CVEs of the opreator

@manuelbuil
Copy link
Collaborator Author

PR ready again. Number of CVEs 0! We tested in our lab and it works

Signed-off-by: Manuel Buil <[email protected]>
@manuelbuil
Copy link
Collaborator Author

@alknopfler could you give it a try at your end just to be sure it works with your usecase?

Copy link
Contributor

@Kristian-ZH Kristian-ZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the PR one more time and all the pods were successfully deployed in the cluster and were running so I'm merging the PR.

@Kristian-ZH Kristian-ZH merged commit 67c733c into suse-edge:main Apr 1, 2024
1 check passed
@alknopfler
Copy link
Contributor

Tested with Kris and now it's easy to pass new nics:
helm install sriov-network-operator . --set supportedExtraNICs[0]="MyNIC: 8086 1521 1520" --set supportedExtraNICs[1]="MyNIC2: 8086 1521 1520"

also it's possible with the helm-values file
thanks @Kristian-ZH for your test and @manuelbuil for the PR

mgfritch added a commit to mgfritch/charts that referenced this pull request Apr 29, 2024
Update to the latest sriov chart and images:
- suse-edge/charts#104
- suse-edge/charts#108

Issue: rancher/rke2#5089
Signed-off-by: Michael Fritch <[email protected]>
mgfritch added a commit to mgfritch/charts that referenced this pull request Apr 30, 2024
Update to the latest sriov chart and images:
- suse-edge/charts#104
- suse-edge/charts#108

Issue: rancher/rke2#5089
Signed-off-by: Michael Fritch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants