Fix notice about duplicate session when multiple instances are created

susanBuck · Nov 1, 2021 · c198dd8 · c198dd8
1 parent 2b8a343
commit c198dd8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/Game.php b/src/Game.php
@@ -17,7 +17,9 @@ class Game
      */
     public function __construct(bool $persistResults = false, int $maxResults = 5, string $timezone = 'America/New_York')
     {
-        session_start();
+        if (session_status() !== PHP_SESSION_ACTIVE) {
+            session_start();
+        }
 
         date_default_timezone_set($timezone);
 

diff --git a/tests/index.php b/tests/index.php
@@ -6,4 +6,7 @@
 
 $game->play('rock');
 
-var_dump($game->getResults());
+var_dump($game->getResults());
+
+# Make sure we can start a new instance without warning about session being already started
+$game2 = new RPS\Game(true);