Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8298 Invalid progress bar layout with default v2 theme within a Bootstrap 5 based project #8350

Merged
merged 2 commits into from
Jun 3, 2024
+16 −0
Merged

#8298 Invalid progress bar layout with default v2 theme within a Bootstrap 5 based project #8350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7cf1e5
#8298 Invalid progress bar layout with default v2 theme within a Boot…
novikov82 Jun 3, 2024
6f5945f
#8298 - update screenshots
novikov82 Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/defaultV2-theme/blocks/sd-progress-buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@
z-index: -1;
border: calcSize(0.5) solid transparent;
border-radius: 50%;
box-sizing: content-box;
}
}
}
Expand Down
Binary file added visualRegressionTests/tests/defaultV2/etalons/survey-progress-bar-bootstrap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 15 additions & 0 deletions visualRegressionTests/tests/defaultV2/progress.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,4 +359,19 @@ frameworks.forEach(framework => {
await takeElementScreenshot("survey-progress-bar-top-rtl.png", Selector(".sd-container-modern"), t, comparer); // title + progress
});
});

test("Check survey with progress and bootstrap", async (t) => {
await wrapVisualTest(t, async (t, comparer) => {
await ClientFunction(() => {
document.head.insertAdjacentHTML("beforeend", "<style>* { box-sizing: border-box; }</style>");
})();
await t.resizeWindow(800, 1080);
await initSurvey(framework, json);
await ClientFunction(() => {
(<any>window).survey.progressBarType = "pages";
(<any>window).survey.currentPageNo = 1;
})();
await takeElementScreenshot("survey-progress-bar-bootstrap.png", Selector(".sd-progress-buttons__list"), t, comparer); // title + progress
});
});
});
Loading