-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: PopupSurveyModel: Redesign #7576
Merged
Merged
Changes from 52 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
20cce76
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 5c12828
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov 3c157f7
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 27a9a17
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 2b28eff
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov e32ee62
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov b21b432
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov 74123a7
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 3d30784
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov 71c6d66
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 1b5461d
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 806e294
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 1ca67e5
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov a2cce8a
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 50aa632
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov d61a6b1
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov aeaf662
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov f4d8736
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov a8680bf
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov 0dda12d
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov f4b0cca
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov debf1d6
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov cd1ce11
work for the https://github.com/surveyjs/service/issues/1668 (lint)
dmitry-kurmanov 0618bb9
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov 8282d63
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov b1b5a6c
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov a52300c
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov a6a3620
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 21e1cd0
Merge branch 'feature/service-1668-popup-survey-model' of https://git…
dmitry-kurmanov 8d5362c
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov 4275443
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov e819d60
work for the https://github.com/surveyjs/service/issues/1668 (lint)
dmitry-kurmanov a78e37c
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 2eeac9a
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov 28a187a
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov d5745fa
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov 861abc0
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov 8fa1427
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 5f41bee
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov 8b8c30d
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov 553b21e
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov c6b2486
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov cea1299
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 46e9516
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov 1c2aeb3
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 50588a2
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov a8fbd13
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov f690660
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov 9758961
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov 4221710
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 280859f
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov fd5486c
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 48b070e
work for the https://github.com/surveyjs/service/issues/1668
dmitry-kurmanov 0e64186
Merge branch 'master' into feature/service-1668-popup-survey-model
dmitry-kurmanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
packages/survey-angular-ui/example/src/app/components/test/test.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
<div id="surveyElement"> | ||
<popup-survey *ngIf="!!model && isPopup" [model]="$any(model)"></popup-survey> | ||
<popup-survey *ngIf="!!model && isPopup" [model]="$any(model)" [isExpanded]="isExpanded" [allowClose]="true"></popup-survey> | ||
<survey *ngIf="!!model && !isPopup" [model]="$any(model)"></survey></div> | ||
<div id="surveyResultElement"></div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 27 additions & 13 deletions
40
packages/survey-angular-ui/src/popup.survey.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,31 @@ | ||
<div *ngIf="!!popup && popup.isShowing" [class]="popup.cssRoot" style="position: fixed; bottom: 3px; right: 10px;" [style.width]="popup.renderedWidth" [style.maxWidth]="popup.renderedWidth"> | ||
<div [class]="popup.cssHeaderRoot"> | ||
<span (click)="popup.changeExpandCollapse()" style="width: 100%; cursor: pointer;"> | ||
<span style="padding-right:10px" [class]="popup.cssHeaderTitle">{{popup.locTitle.renderedHtml}}</span> | ||
<span aria-hidden="true" [class]="popup.cssButton"></span> | ||
</span> | ||
<span *ngIf="popup.allowClose" (click)="popup.hide()" [class]="popup.cssHeaderButton" style="float: right; cursor: pointer; width: 24px; height: 24px; transform: rotate(45deg);"> | ||
<svg [iconName]="'icon-expanddetail'" [size]="16" sv-ng-svg-icon></svg> | ||
</span> | ||
<span *ngIf="popup.isExpanded" (click)="popup.changeExpandCollapse()" [class]="popup.cssHeaderButton" style="float: right; cursor: pointer; width: 24px; height: 24px;"> | ||
<svg [iconName]="'icon-collapsedetail'" [size]="16" sv-ng-svg-icon></svg> | ||
</span> | ||
<div *ngIf="!!popup && popup.isShowing" [class]="popup.cssRoot" [style.width]="popup.renderedWidth" [style.maxWidth]="popup.renderedWidth" (scroll)="popup.onScroll()"> | ||
<div [class]="popup.cssRootContent"> | ||
<div [class]="getHeaderCss()"> | ||
<div *ngIf="popup.isCollapsed && !!popup.locTitle" [class]="popup.cssHeaderTitleCollapsed"> | ||
{{popup.locTitle.renderedHtml}} | ||
</div> | ||
<div [class]="popup.cssHeaderButtonsContainer"> | ||
<div [class]="popup.cssHeaderCollapseButton" (click)="popup.changeExpandCollapse()"> | ||
<!-- <svg *ngIf="popup.isExpanded" [iconName]="'icon-minimize_16x16'" [size]="16" sv-ng-svg-icon></svg> --> | ||
<svg *ngIf="popup.isExpanded" class="sv-svg-icon" width="16" height="16" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg"> | ||
<path d="M13 9H3C2.45 9 2 8.55 2 8C2 7.45 2.45 7 3 7H13C13.55 7 14 7.45 14 8C14 8.55 13.55 9 13 9Z"/> | ||
</svg> | ||
<!-- <svg *ngIf="popup.isCollapsed" [iconName]="'icon-restore_16x16'" [size]="16" sv-ng-svg-icon></svg> --> | ||
<svg *ngIf="popup.isCollapsed" class="sv-svg-icon" width="16" height="16" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg"> | ||
<path d="M12 13H4C2.9 13 2 12.1 2 11V5C2 3.9 2.9 3 4 3H12C13.1 3 14 3.9 14 5V11C14 12.1 13.1 13 12 13ZM4 5V11H12V5H4Z"/> | ||
</svg> | ||
</div> | ||
|
||
<div *ngIf="popup.allowClose" [class]="popup.cssHeaderCloseButton" (click)="popup.hide()"> | ||
<!-- <svg [iconName]="'icon-close_16x16'" [size]="16" sv-ng-svg-icon></svg> --> | ||
<svg class="sv-svg-icon" role="img" width="16" height="16" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg"> | ||
<path d="M9.43 8.0025L13.7 3.7225C14.09 3.3325 14.09 2.6925 13.7 2.2925C13.31 1.9025 12.67 1.9025 12.27 2.2925L7.99 6.5725L3.72 2.3025C3.33 1.9025 2.69 1.9025 2.3 2.3025C1.9 2.6925 1.9 3.3325 2.3 3.7225L6.58 8.0025L2.3 12.2825C1.91 12.6725 1.91 13.3125 2.3 13.7125C2.69 14.1025 3.33 14.1025 3.73 13.7125L8.01 9.4325L12.29 13.7125C12.68 14.1025 13.32 14.1025 13.72 13.7125C14.11 13.3225 14.11 12.6825 13.72 12.2825L9.44 8.0025H9.43Z"/> | ||
</svg> | ||
</div> | ||
</div> | ||
</div> | ||
<div *ngIf="popup.isExpanded" [class]="popup.cssBody" (scroll)="popup.onScroll()"> | ||
<div *ngIf="popup.isExpanded" [class]="popup.cssBody"> | ||
<survey [model]="popup.survey"></survey> | ||
</div> | ||
</div> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,60 +1,40 @@ | ||
<template> | ||
<div | ||
v-if="surveyWindow.isShowing" | ||
style="position: fixed; bottom: 3px; right: 10px" | ||
:style="{ | ||
maxWidth: surveyWindow.renderedWidth, | ||
width: surveyWindow.renderedWidth, | ||
}" | ||
:class="surveyWindow.cssRoot" | ||
> | ||
<div :class="surveyWindow.cssHeaderRoot"> | ||
<span | ||
@click="doExpand" | ||
style="width: 100%; cursor: pointer; user-select: none" | ||
> | ||
<span style="padding-right: 10px" :class="surveyWindow.cssHeaderTitle"> | ||
<survey-string :locString="survey.locTitle" /> | ||
</span> | ||
<span aria-hidden="true" :class="expandedCss"></span> | ||
</span> | ||
<span | ||
v-if="surveyWindow.allowClose" | ||
:class="surveyWindow.cssHeaderButton" | ||
@click="doHide" | ||
style=" | ||
transform: rotate(45deg); | ||
float: right; | ||
cursor: pointer; | ||
user-select: none; | ||
width: 24px; | ||
height: 24px; | ||
" | ||
> | ||
<sv-svg-icon :iconName="'icon-expanddetail'" :size="16"> </sv-svg-icon> | ||
</span> | ||
<span | ||
v-if="isExpandedSurvey" | ||
:class="surveyWindow.cssHeaderButton" | ||
@click="doExpand" | ||
style=" | ||
float: right; | ||
cursor: pointer; | ||
user-select: none; | ||
width: 24px; | ||
height: 24px; | ||
" | ||
> | ||
<sv-svg-icon :iconName="'icon-collapsedetail'" :size="16"> | ||
</sv-svg-icon> | ||
</span> | ||
</div> | ||
<div | ||
v-if="isExpandedSurvey" | ||
:class="surveyWindow.cssBody" | ||
@scroll="doScroll" | ||
> | ||
<component :is="getSurveyComponentName()" :survey="survey"> </component> | ||
<div v-if="surveyWindow.isShowing" :style="{ maxWidth: surveyWindow.renderedWidth, width: surveyWindow.renderedWidth }" | ||
:class="surveyWindow.cssRoot" @scroll="doScroll"> | ||
<div :class="surveyWindow.cssRootContent"> | ||
<div :class="cssHeaderRoot()"> | ||
<div v-if="surveyWindow.isCollapsed && !!surveyWindow.locTitle" :class="surveyWindow.cssHeaderTitleCollapsed"> | ||
{{ surveyWindow.locTitle.renderedHtml }} | ||
</div> | ||
|
||
<div :class="surveyWindow.cssHeaderButtonsContainer"> | ||
<div :class="surveyWindow.cssHeaderCollapseButton" @click="doExpand"> | ||
<!-- <sv-svg-icon v-if="surveyWindow.isExpanded" :iconName="'icon-minimize_16x16'" :size="16"> </sv-svg-icon> --> | ||
<svg v-if="surveyWindow.isExpanded" className="sv-svg-icon" width="16" height="16" viewBox="0 0 16 16" | ||
xmlns="http://www.w3.org/2000/svg"> | ||
<path d="M13 9H3C2.45 9 2 8.55 2 8C2 7.45 2.45 7 3 7H13C13.55 7 14 7.45 14 8C14 8.55 13.55 9 13 9Z" /> | ||
</svg> | ||
<!-- <sv-svg-icon v-if="surveyWindow.isCollapsed" :iconName="'icon-restore_16x16'" :size="16"> </sv-svg-icon> --> | ||
<svg v-if="surveyWindow.isCollapsed" className="sv-svg-icon" width="16" height="16" viewBox="0 0 16 16" | ||
xmlns="http://www.w3.org/2000/svg"> | ||
<path | ||
d="M12 13H4C2.9 13 2 12.1 2 11V5C2 3.9 2.9 3 4 3H12C13.1 3 14 3.9 14 5V11C14 12.1 13.1 13 12 13ZM4 5V11H12V5H4Z" /> | ||
</svg> | ||
</div> | ||
|
||
<div v-if="surveyWindow.allowClose" :class="surveyWindow.cssHeaderCloseButton" @click="doHide"> | ||
<svg className="sv-svg-icon" role="img" width="16" height="16" viewBox="0 0 16 16" | ||
xmlns="http://www.w3.org/2000/svg"> | ||
<path | ||
d="M9.43 8.0025L13.7 3.7225C14.09 3.3325 14.09 2.6925 13.7 2.2925C13.31 1.9025 12.67 1.9025 12.27 2.2925L7.99 6.5725L3.72 2.3025C3.33 1.9025 2.69 1.9025 2.3 2.3025C1.9 2.6925 1.9 3.3325 2.3 3.7225L6.58 8.0025L2.3 12.2825C1.91 12.6725 1.91 13.3125 2.3 13.7125C2.69 14.1025 3.33 14.1025 3.73 13.7125L8.01 9.4325L12.29 13.7125C12.68 14.1025 13.32 14.1025 13.72 13.7125C14.11 13.3225 14.11 12.6825 13.72 12.2825L9.44 8.0025H9.43Z" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need |
||
</svg> | ||
<!-- <sv-svg-icon :iconName="'icon-close_16x16'" :size="16"> </sv-svg-icon> --> | ||
</div> | ||
</div> | ||
</div> | ||
<div v-if="isExpandedSurvey" :class="surveyWindow.cssBody"> | ||
<component :is="getSurveyComponentName()" :survey="survey"> </component> | ||
</div> | ||
</div> | ||
</div> | ||
</template> | ||
|
@@ -67,6 +47,7 @@ import { useBase } from "./base"; | |
const props = defineProps<{ | ||
survey: SurveyModel; | ||
isExpanded: boolean; | ||
allowClose: boolean; | ||
closeOnCompleteTimeout: number; | ||
}>(); | ||
const surveyWindow = | ||
|
@@ -96,6 +77,14 @@ const doScroll = () => { | |
surveyWindow.value.onScroll(); | ||
}; | ||
|
||
const cssHeaderRoot = () => { | ||
let headerCss = surveyWindow.value.cssHeaderRoot; | ||
if (surveyWindow.value.isCollapsed) { | ||
headerCss += " " + surveyWindow.value.cssRootCollapsedMod; | ||
} | ||
return headerCss; | ||
} | ||
|
||
useBase(() => surveyWindow.value); | ||
|
||
const stopWatch = watch( | ||
|
@@ -108,6 +97,9 @@ const stopWatch = watch( | |
if (props.closeOnCompleteTimeout !== undefined) { | ||
model.closeOnCompleteTimeout = props.closeOnCompleteTimeout; | ||
} | ||
if (props.allowClose !== undefined) { | ||
model.allowClose = props.allowClose; | ||
} | ||
model.isShowing = true; | ||
surveyWindow.value = model; | ||
}, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,62 +1,86 @@ | ||
@import "../defaultV2-theme/variables.scss"; | ||
@import "../defaultV2-theme/mixins.scss"; | ||
|
||
.sv_window { | ||
position: fixed; | ||
bottom: 3px; | ||
right: 10px; | ||
background-color: cadetblue; | ||
padding: 1px; | ||
font-family: $font-family; | ||
font-size: calcFontSize(0.875); | ||
font-style: normal; | ||
font-weight: 400; | ||
line-height: 1.42857143; | ||
text-align: left; | ||
text-align: start; | ||
text-decoration: none; | ||
text-shadow: none; | ||
text-transform: none; | ||
letter-spacing: normal; | ||
word-break: normal; | ||
word-spacing: normal; | ||
word-wrap: normal; | ||
white-space: normal; | ||
background-color: #fff; | ||
-webkit-background-clip: padding-box; | ||
bottom: calcSize(2); | ||
right: calcSize(2); | ||
border-radius: calcSize(1); | ||
border: 1px solid $border-inside; | ||
box-shadow: $shadow-large, $shadow-medium; | ||
background-clip: padding-box; | ||
border: 1px solid #ccc; | ||
border: 1px solid rgba(0, 0, 0, 0.2); | ||
border-radius: calcCornerRadius(1.5); | ||
-webkit-box-shadow: 0 5px 10px rgba(0, 0, 0, 0.2); | ||
box-shadow: 0 5px 10px rgba(0, 0, 0, 0.2); | ||
line-break: auto; | ||
z-index: 100; | ||
max-height: 90vh; | ||
overflow: auto; | ||
box-sizing: border-box; | ||
} | ||
|
||
.sv_window_title { | ||
padding: 8px 14px; | ||
margin: 0; | ||
font-size: calcFontSize(0.875); | ||
background-color: #f7f7f7; | ||
border-bottom: 1px solid #ebebeb; | ||
border-radius: calcCornerRadius(1) calcCornerRadius(1) 0 0; | ||
display: flex; | ||
.sv_window_content { | ||
border-radius: calcSize(1); | ||
overflow: hidden; | ||
} | ||
|
||
.sv_window_content { | ||
padding: 0; | ||
margin: 0; | ||
max-height: 80vh; | ||
overflow-y: auto; | ||
.sv_window--collapsed { | ||
.sv_window_header { | ||
height: calcSize(4); | ||
padding: calcSize(1) calcSize(1) calcSize(1) calcSize(2); | ||
border-radius: calcSize(1); | ||
display: flex; | ||
background-color: $background-dim; | ||
} | ||
} | ||
|
||
.sv_window_header_title_collapsed { | ||
color: $foreground-dim; | ||
@include defaultBold; | ||
flex: 1; | ||
display: flex; | ||
justify-content: start; | ||
align-items: center; | ||
} | ||
|
||
.sv_window_title a, | ||
.sv_window_title a:link, | ||
.sv_window_title a:visited { | ||
text-decoration: none; | ||
font-size: calcFontSize(0.875); | ||
font-style: normal; | ||
color: black; | ||
.sv_window_header_description{ | ||
color: $font-questiondescription-color; | ||
font-feature-settings: 'salt' on; | ||
@include defaultFont; | ||
white-space: nowrap; | ||
text-overflow: ellipsis; | ||
overflow: hidden; | ||
} | ||
|
||
.sv_window_button .sv-svg-icon { | ||
margin: 4px; | ||
.sv_window_buttons_container { | ||
position: absolute; | ||
top: calcSize(1); | ||
right: calcSize(1); | ||
display: flex; | ||
gap: calcSize(1); | ||
z-index: 1; | ||
} | ||
|
||
.sv_window_button { | ||
display: flex; | ||
padding: calcSize(1); | ||
justify-content: center; | ||
align-items: center; | ||
border-radius: calcSize(0.5); | ||
cursor: pointer; | ||
|
||
&:hover, &:active { | ||
background-color: $primary-light; | ||
svg { | ||
use, path { | ||
fill: $primary; | ||
} | ||
} | ||
} | ||
|
||
&:active { | ||
opacity: 0.5; | ||
} | ||
|
||
svg { | ||
use, path { | ||
fill: $foreground-dim-light; | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need
sv-svg-icon
component here