Fix: Prevent clear of other questions when question name equals other value name #7517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the values of all invisible questions are cleared on complete to exclude the data from the result. As multiple questions may have the same value name, it is checked wherever there is another question with the same value name is visible before clearing the value.
However, this check does not take into account, that the question name is the default value name when no value name is provided. This causes all questions with the same value name as the question name to be cleared.
This PR suggests using
getValueName
instead, which falls back to the question name if no value name is defined.Example Survey