Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/7035 notify wait user action #7317

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Bug/7035 notify wait user action #7317

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9f9e1f
Add waitUserAction parameter into survey.notify #7035
andrewtelnov Nov 9, 2023
33a48d4
use showActions to wait for actions
andrewtelnov Nov 9, 2023
1ac2af5
Change notify call
andrewtelnov Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/survey.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3288,12 +3288,12 @@ export class SurveyModel extends SurveyElementCore
}
this.setPropertyValue("completedStateText", text);
if (this.state === "completed" && this.showCompletedPage && !!this.completedState) {
this.notify(this.completedStateText, this.completedState, true);
this.notify(this.completedStateText, this.completedState, value === "error");
}
}
public notify(message: string, type: string, showActions: boolean = false): void {
this.notifier.showActions = showActions;
this.notifier.notify(message, type, type === "error");
this.notifier.notify(message, type, showActions);
}
/**
* Resets the survey [`state`](https://surveyjs.io/form-library/documentation/api-reference/survey-data-model#state) and, optionally, [`data`](https://surveyjs.io/form-library/documentation/api-reference/survey-data-model#data). If `state` is `"completed"`, it becomes `"running"`.
Expand Down