Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/7219-Signature-Pad-is-not-Responsive-on-Mobile-Screens #7284

Merged
merged 11 commits into from
Nov 3, 2023
Merged

Issue/7219-Signature-Pad-is-not-Responsive-on-Mobile-Screens #7284

merged 11 commits into from
Nov 3, 2023

Conversation

novikov82
Copy link
Contributor

Fixes #7219

@novikov82
Copy link
Contributor Author

@RomanTsukanov we need to describe this properties:
https://github.com/surveyjs/survey-library/pull/7284/files#diff-56fcd01c0c08b1327bf774d29516820047e7a5a410ca987f6446b4c62e5ef679R198-R200

For understanding penMinWidth and penMaxWidth see minWidth and maxWidth options from signature_pad library https://github.com/szimek/signature_pad#options (of course we can rename them if need)

@novikov82 novikov82 marked this pull request as ready for review November 3, 2023 13:05
@novikov82 novikov82 requested a review from dk981234 November 3, 2023 13:54
@dk981234 dk981234 merged commit 4bcf7b2 into master Nov 3, 2023
18 checks passed
@dk981234 dk981234 deleted the issue/7219-Signature-Pad-is-not-Responsive-on-Mobile-Screens branch November 3, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dk981234 dk981234 dk981234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signature Pad is not Responsive on Mobile Screens
3 participants
@novikov82 @dk981234 @RomanTsukanov