Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer doesn't stop at 0 when a survey has validation errors #7507

Closed
JaneSjs opened this issue Dec 15, 2023 · 1 comment · Fixed by #7526 or #7590
Closed

Timer doesn't stop at 0 when a survey has validation errors #7507

JaneSjs opened this issue Dec 15, 2023 · 1 comment · Fixed by #7526 or #7590
Assignees
@tsv2013
Labels
bug user issue An issue or bug reported by users
Milestone
v1.9.124

Comments

@JaneSjs
Copy link
Contributor

JaneSjs commented Dec 15, 2023

User Issue: T16024 - Clock font size, overdue minus value
https://surveyjs.answerdesk.io/internal/ticket/details/T16024

If a survey has a timer and validation rules, the following happens: if a survey tries to complete but validation errors occur, the timer continues counting the time in reverse:
image

Expected behavior: when the time elapses but validation errors occur, the timer stops at 0. A user has to correct validation errors to manually complete the survey.
@JaneSjs JaneSjs added bug user issue An issue or bug reported by users labels Dec 15, 2023
andrewtelnov added a commit that referenced this issue Dec 18, 2023
@andrewtelnov
Survey Timer and Validation - The timer should stop at 0 and wait unt…
bc36d7d 
…il a user corrects validation errors fix #7507
@andrewtelnov andrewtelnov mentioned this issue Dec 18, 2023
Merged
tsv2013 pushed a commit that referenced this issue Dec 18, 2023
@andrewtelnov
Survey Timer and Validation - The timer should stop at 0 and wait unt…
7379cd3 
…il a user corrects validation errors fix #7507 (#7526)
@RomanTsukanov RomanTsukanov changed the title Survey Timer and Validation - The timer should stop at 0 and wait until a user corrects validation errors Timer doesn't stop at 0 when a survey has validation errors Dec 19, 2023
@JaneSjs
Copy link
Contributor Author

JaneSjs commented Dec 26, 2023

The timer is not actually stopped.
image

https://plnkr.co/edit/n6LwTbfp1iolAE9Q

@JaneSjs JaneSjs reopened this Dec 26, 2023
@JaneSjs JaneSjs assigned tsv2013 and unassigned andrewtelnov Dec 26, 2023
tsv2013 pushed a commit that referenced this issue Dec 27, 2023
Fixed #7507 - Timer doesn't stop at 0 when a survey has validation er…
3c7e4f8 
…rors
@tsv2013 tsv2013 mentioned this issue Dec 27, 2023
Merged
dk981234 added a commit that referenced this issue Dec 28, 2023
@dk981234
Merge pull request #7590 from surveyjs/bug/7507-stop-progress
8ac0c6f 
Fixed #7507 - Timer doesn't stop at 0 when a survey has validation errors
@OlgaLarina OlgaLarina added this to the v1.9.124 milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsv2013 tsv2013

Labels
bug user issue An issue or bug reported by users
Projects
None yet
Milestone
v1.9.124
4 participants
@tsv2013 @andrewtelnov @OlgaLarina @JaneSjs