Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

options within the onDragDropAllow event API have incorrect names #7336

Closed
RomanTsukanov opened this issue Nov 13, 2023 · 1 comment
Closed

options within the onDragDropAllow event API have incorrect names #7336

RomanTsukanov opened this issue Nov 13, 2023 · 1 comment
Assignees
@RomanTsukanov @dmitry-kurmanov
Labels
API change Issues that request changes in the API
Milestone
v1.9.118

Comments

@RomanTsukanov
Copy link
Contributor

To disambiguate the onDragDropAllow API and unify it with the API of onDragStart and onDragEnd events, we need to make the following changes:

options.source -> options.draggedElement
options.target -> options.toElement

  • add options.fromElement
@RomanTsukanov RomanTsukanov added the API change Issues that request changes in the API label Nov 13, 2023
@RomanTsukanov RomanTsukanov mentioned this issue Nov 13, 2023
Closed
@dmitry-kurmanov
Copy link
Member

dmitry-kurmanov commented Nov 17, 2023 •
edited
Loading

for further info see https://github.com/surveyjs/survey-creator/pull/4580/files

dmitry-kurmanov added a commit to surveyjs/survey-creator that referenced this issue Nov 17, 2023
@dmitry-kurmanov
work for the surveyjs/survey-library#7336
519da82
dmitry-kurmanov added a commit that referenced this issue Nov 17, 2023
@dmitry-kurmanov
work for the #7336
720b1fb
dmitry-kurmanov added a commit that referenced this issue Nov 17, 2023
@dmitry-kurmanov
work for the #7336
209b63a
This was referenced Nov 17, 2023
Merged
Merged
dmitry-kurmanov added a commit that referenced this issue Nov 20, 2023
@dmitry-kurmanov @RomanTsukanov
PR: LIBRARY: Change onDragDropAllow options (#7370)
b11fa06 
* work for the #7336

* work for the #7336

* Fix descriptions

---------

Co-authored-by: RomanTsukanov <[email protected]>
@dmitry-kurmanov dmitry-kurmanov added this to the v1.9.118 milestone Nov 20, 2023
@RomanTsukanov RomanTsukanov changed the title Change onDragDropAllow options Fix the onDragDropAllow event API Nov 21, 2023
@RomanTsukanov RomanTsukanov changed the title Fix the onDragDropAllow event API options within the onDragDropAllow event API have incorrect names Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanTsukanov RomanTsukanov

@dmitry-kurmanov dmitry-kurmanov

Labels
API change Issues that request changes in the API
Projects
None yet
Milestone
v1.9.118
Development

No branches or pull requests
2 participants
@RomanTsukanov @dmitry-kurmanov