Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken drop-down menu. #7000

Closed
4 tasks
mikeamelin opened this issue Sep 23, 2023 · 0 comments · Fixed by #7140
Closed
4 tasks

Broken drop-down menu. #7000

mikeamelin opened this issue Sep 23, 2023 · 0 comments · Fixed by #7140
Assignees
@dk981234
Labels
bug mobile/tablet
Milestone
v1.9.113

Comments

@mikeamelin
Copy link

mikeamelin commented Sep 23, 2023 •
edited
Loading

For mobile (iPad) at least it is...

  • space below search
  • a bit wrong padding for search editor
  • wrong alignment for Cancel button

https://www.figma.com/file/i6Lpc7zkjHtso2oXZV97fo/*-Components?type=design&node-id=15811-137281&mode=design&t=ziDEDctgrSQ8iJ59-4

Image

  • also let's remove top/bottom additional padding for desktop (8px –> 4 px)

https://www.figma.com/file/i6Lpc7zkjHtso2oXZV97fo/*-Components?type=design&node-id=2246-73339&mode=design&t=ziDEDctgrSQ8iJ59-4

Image
@mikeamelin mikeamelin self-assigned this Sep 23, 2023
@mikeamelin mikeamelin changed the title Broken drop-down menu. Brocken drop-down menu. Sep 23, 2023
@mikeamelin mikeamelin changed the title Brocken drop-down menu. Broken drop-down menu. Sep 23, 2023
@dk981234 dk981234 assigned dk981234 and unassigned OlgaLarina Oct 10, 2023
dk981234 added a commit that referenced this issue Oct 13, 2023
@dk981234
Work for #7000: fix dropdown popup styles
c3fbd57
@dk981234 dk981234 linked a pull request Oct 13, 2023 that will close this issue
Implement styles for mobile dropdown popups + fix popup styles #7140
Merged
tsv2013 pushed a commit that referenced this issue Oct 16, 2023
@dk981234
Implement styles for mobile dropdown popups + fix popup styles (#7140)
c729c55 
* Work for #7000: fix dropdown popup styles

* Fix toc navigation popup

* Update etalons

* Update markup snapshots

* Fix f tests

* Update vrt etalon
@mikeamelin mikeamelin removed their assignment Oct 17, 2023
@OlgaLarina OlgaLarina added this to the v1.9.113 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dk981234 dk981234

Labels
bug mobile/tablet
Projects
None yet
Milestone
v1.9.113
Development

Successfully merging a pull request may close this issue.

Implement styles for mobile dropdown popups + fix popup styles surveyjs/survey-library
3 participants
@OlgaLarina @mikeamelin @dk981234