Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read-only and Preview Mode: Redesign: Root Issue #6776

Closed
21 of 23 tasks
tsv2013 opened this issue Aug 23, 2023 · 7 comments · Fixed by #7999
Closed
21 of 23 tasks

Read-only and Preview Mode: Redesign: Root Issue #6776

tsv2013 opened this issue Aug 23, 2023 · 7 comments · Fixed by #7999
Assignees
@dmitry-kurmanov @novikov82
Labels
enhancement user issue An issue or bug reported by users
Milestone
v1.9.139

Comments

@tsv2013
Copy link
Member

tsv2013 commented Aug 23, 2023 •
edited by dmitry-kurmanov
Loading

We need to distinguish the disabled and read-only (display) mode of survey questions.
@mikeamelin created design for this states:

Details — https://docs.google.com/document/d/1xE_qzePrSRulQa7VS9ambu8JdXJsFBwDt1eg2Ue8ZFM/edit?usp=sharing
Design — https://www.figma.com/file/jcuAUsN02n2yJerx39mqf9/Previews?type=design&node-id=101-7&mode=dev

Dev TODO
@JaneSjs
Copy link
Contributor

JaneSjs commented Nov 10, 2023 •
edited
Loading

User Requests:

@JaneSjs JaneSjs added the user issue An issue or bug reported by users label Dec 18, 2023
dmitry-kurmanov added a commit that referenced this issue Mar 20, 2024
@dmitry-kurmanov
work for the #6776
2e4fe81
@dmitry-kurmanov dmitry-kurmanov changed the title Read-only and disabled state indication and rendering Read-only and Preview Mode: Redesign Mar 20, 2024
@dmitry-kurmanov dmitry-kurmanov changed the title Read-only and Preview Mode: Redesign Read-only and Preview Mode: Redesign: Root Issue Mar 20, 2024
@dmitry-kurmanov dmitry-kurmanov mentioned this issue Mar 20, 2024
Merged
@JaneSjs
Copy link
Contributor

JaneSjs commented Mar 20, 2024

T17346 - Make font color of readonly values darker?
https://surveyjs.answerdesk.io/internal/ticket/details/T17346

dmitry-kurmanov added a commit that referenced this issue Mar 21, 2024
@dmitry-kurmanov
work for the #6776
558cebc
dmitry-kurmanov added a commit that referenced this issue Mar 21, 2024
@dmitry-kurmanov
work for the #6776
e1bd845
dmitry-kurmanov added a commit that referenced this issue Mar 22, 2024
@dmitry-kurmanov
work for the #6776
acd2bc0
novikov82 added a commit that referenced this issue Mar 25, 2024
@novikov82
#6776 - implemented preview for rating stars and skipped tests for di…
1bfaa13 
…sabled
novikov82 added a commit that referenced this issue Mar 25, 2024
@novikov82
#6776 - dropdown, tagbox
eb1cb13
novikov82 added a commit that referenced this issue Mar 25, 2024
@novikov82
#6776 - fixed u-tests
f5388b9
novikov82 added a commit that referenced this issue Mar 25, 2024
@novikov82
#6776 - comment and fix singleinput test
5e7cf53
novikov82 added a commit that referenced this issue Mar 25, 2024
@novikov82
#6776 - multipletext
15a5ae5
novikov82 added a commit that referenced this issue Mar 25, 2024
@novikov82
#6776 - fixed u-tests
9cb6b35
novikov82 added a commit that referenced this issue Mar 25, 2024
@novikov82
#6776 - fixed some v-tests
349ccb1
dmitry-kurmanov added a commit that referenced this issue Mar 26, 2024
@dmitry-kurmanov
work for the #6776 (checkbox group)
036cfb5
dmitry-kurmanov added a commit that referenced this issue Mar 26, 2024
@dmitry-kurmanov
work for the #6776 (checkbox group)
75ae305
novikov82 added a commit that referenced this issue Mar 26, 2024
@novikov82
#6776 - fix rating small stars
4455a37
novikov82 added a commit that referenced this issue Mar 26, 2024
@novikov82
#6776 - try to fix responsivity test
0c1cfb0
dmitry-kurmanov added a commit that referenced this issue Mar 26, 2024
@dmitry-kurmanov
work for the #6776 (ranking spike)
e672ef9
novikov82 added a commit that referenced this issue Mar 26, 2024
@novikov82
#6776 - try to fix angular test
86e5812
novikov82 added a commit that referenced this issue Mar 26, 2024
@novikov82
#6776 - fix rating in matrix test
3b87b93
novikov82 added a commit that referenced this issue Mar 26, 2024
@novikov82
#6776 - remove DIM color
77c5fd0
novikov82 pushed a commit that referenced this issue Mar 26, 2024
#6776 - fixed build
99d99eb
novikov82 added a commit that referenced this issue Mar 27, 2024
@novikov82
#6776 - skip matrix preview test for angular
28b2e2a
dmitry-kurmanov added a commit that referenced this issue Apr 9, 2024
@dmitry-kurmanov
work for the #6776
f2d4b3d
@JaneSjs
Copy link
Contributor

JaneSjs commented Apr 9, 2024

+1 #8055

@JaneSjs JaneSjs mentioned this issue Apr 9, 2024
Closed
dmitry-kurmanov added a commit that referenced this issue Apr 9, 2024
@dmitry-kurmanov
work for the #6776
8ab4b70
@mikeamelin
Copy link

mikeamelin commented Apr 10, 2024 •
edited by dmitry-kurmanov
Loading

  • there we should use another background color for read-only

https://www.figma.com/file/i6Lpc7zkjHtso2oXZV97fo/*-Components?type=design&node-id=19925-1262932&mode=design&t=kUI5IeJ7yhJgoE6N-4
Image

https://www.figma.com/file/i6Lpc7zkjHtso2oXZV97fo/*-Components?type=design&node-id=19925-1258280&mode=design&t=kUI5IeJ7yhJgoE6N-4
Image

https://www.figma.com/file/i6Lpc7zkjHtso2oXZV97fo/*-Components?type=design&node-id=18229-396599&mode=design&t=kUI5IeJ7yhJgoE6N-4
Image

  • let's change background color for alt row everywhere

https://www.figma.com/file/i6Lpc7zkjHtso2oXZV97fo/*-Components?type=design&node-id=19925-1340814&mode=design&t=kUI5IeJ7yhJgoE6N-4
Image

novikov82 added a commit that referenced this issue Apr 10, 2024
@novikov82
#6776 - update screenshot
8be32a5
dmitry-kurmanov added a commit that referenced this issue Apr 10, 2024
@dmitry-kurmanov
work for the #6776
38929aa
novikov82 added a commit that referenced this issue Apr 10, 2024
@novikov82
#6776 - update preview etalons for dynamic panel
92fbef7
novikov82 added a commit that referenced this issue Apr 10, 2024
@novikov82
#6776 - vixed matrix altrow backcolor
bb3a490
dmitry-kurmanov added a commit that referenced this issue Apr 11, 2024
@dmitry-kurmanov
work for the #6776
7d424dc
novikov82 added a commit that referenced this issue Apr 11, 2024
@novikov82
#6776 - fixed radio checkbox color
7e656a6
novikov82 added a commit that referenced this issue Apr 12, 2024
@novikov82
#6776 - update screenshots
15a3957
novikov82 added a commit that referenced this issue Apr 12, 2024
@novikov82
#6776 - fixed dynamic panel rendering
80db178
dmitry-kurmanov added a commit that referenced this issue Apr 12, 2024
@dmitry-kurmanov
work for the #6776
7962636
novikov82 added a commit that referenced this issue Apr 12, 2024
@novikov82
#6776 - add dot to "no signature"
5fe8dd4
dmitry-kurmanov added a commit that referenced this issue Apr 12, 2024
@dmitry-kurmanov
work for the #6776
fd3f520
novikov82 added a commit that referenced this issue Apr 12, 2024
@novikov82
#6776 - fix matrix input color for altrow
61f0b4f
novikov82 added a commit that referenced this issue Apr 12, 2024
@novikov82
#6776 - fix angular dynamic panels
7b19cef
novikov82 added a commit that referenced this issue Apr 12, 2024
@novikov82
#6776 - fixed boolean radio rendering
6a495c6
dmitry-kurmanov added a commit that referenced this issue Apr 15, 2024
@dmitry-kurmanov
work for the #6776
6b5399f
dmitry-kurmanov added a commit that referenced this issue Apr 15, 2024
@dmitry-kurmanov
work for the #6776
1a40311
novikov82 added a commit that referenced this issue Apr 15, 2024
@novikov82
#6776 - fix markup tests
430d908
novikov82 added a commit that referenced this issue Apr 15, 2024
@novikov82
#6776 - fixed boolean paddings
8ebbeb1
novikov82 added a commit that referenced this issue Apr 15, 2024
@novikov82
#6776 - update boolean screenshots
164cd05
dmitry-kurmanov added a commit that referenced this issue Apr 16, 2024
@dmitry-kurmanov
work for the #6776
c745534
dmitry-kurmanov added a commit that referenced this issue Apr 16, 2024
@dmitry-kurmanov
work for the #6776
9fb56fc
novikov82 added a commit that referenced this issue Apr 16, 2024
@novikov82
#6776 - simplify code
b1868cb
novikov82 added a commit that referenced this issue Apr 16, 2024
@dmitry-kurmanov @novikov82
PR: Read-only and Preview Mode: Redesign: Root Issue (#7999)
4512328 
* work for the #6776

* work for the #6776

* work for the #6776

* work for the #6776

* #6776 - implemented preview for rating stars and skipped tests for disabled

* #6776 - dropdown, tagbox

* #6776 - fixed u-tests

* #6776 - comment and fix singleinput test

* #6776 - multipletext

* #6776 - fixed u-tests

* #6776 - fixed some v-tests

* work for the #6776 (checkbox group)

* work for the #6776 (checkbox group)

* #6776 - fix rating small stars

* #6776 - try to fix responsivity test

* work for the #6776 (ranking spike)

* work for the surveyjs/service#1464 (ranking)

* #6776 - try to fix angular test

* #6776 - fix rating in matrix test

* #6776 - remove DIM color

* #6776 - fixed build

* #6776 - skip matrix preview test for angular

* #6776 - revert angular test skip

* work for the #6776 (boolean, boolean:radio, boolean:checkbox)

* work for the #6776 (boolean markup)

* work for the #6776 (imagepicker)

* #6776 - matrix single-choice

* #6776 - support disabled in old themes

* work for the #6776 (file)

* work for the #6776 (test.only)

* work for the #6776 (review)

* #6676 - fixed selection in readonly and preview mode

* work for the #6776

* #6776 - colored rating

* #6776 - fixed markup tests

* #6779 - matrix alt-rows

* #6776

* #6776 - fixed v-tests

* work for the #6776

* #6776 - siganture, dynamic panel

* #6776 - signature and panel

* work for the #6776

* work for the #6776

* #6776 - update screenshot

* Update readonly-preview.ts

* work for the #6776

* #6776 - update preview etalons for dynamic panel

* #6776 - vixed matrix altrow backcolor

* work for the #6776

* #6776 - fixed radio checkbox color

* #6776 - update screenshots

* #6776 - fixed dynamic panel rendering

* work for the #6776

* work for the #6776

* #6776 - add dot to "no signature"

* #6776 - fix matrix input color for altrow

* #6776 - fix angular dynamic panels

* #6776 - fixed boolean radio rendering

* work for the #6776

* work for the #6776

* #6776 - fix markup tests

* #6776 - fixed boolean paddings

* #6776 - update boolean screenshots

* work for the #6776

* work for the #6776

* #6776 - simplify code

---------

Co-authored-by: Aleksey Novikov <[email protected]>
Co-authored-by: Aleksey Novikov <[email protected]>
@OlgaLarina OlgaLarina added this to the v1.9.139 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitry-kurmanov dmitry-kurmanov

@novikov82 novikov82

Labels
enhancement user issue An issue or bug reported by users
Projects
None yet
Milestone
v1.9.139
Development

Successfully merging a pull request may close this issue.

PR: Read-only and Preview Mode: Redesign: Root Issue surveyjs/survey-library
6 participants
@tsv2013 @OlgaLarina @mikeamelin @dmitry-kurmanov @JaneSjs @novikov82