Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme builder: image settings issues #6655

Closed
4 tasks
OlgaLarina opened this issue Jul 25, 2023 · 1 comment · Fixed by #6864
Closed
4 tasks

Theme builder: image settings issues #6655

OlgaLarina opened this issue Jul 25, 2023 · 1 comment · Fixed by #6864
Assignees
@tsv2013 @OlgaLarina @mikeamelin @RomanTsukanov
Labels
theme builder website demos
Milestone
v1.9.111

Comments

@OlgaLarina
Copy link
Collaborator

OlgaLarina commented Jul 25, 2023 •
edited
Loading

https://github.com/surveyjs/private-tasks/issues/243#issuecomment-1640357748
https://github.com/surveyjs/private-tasks/issues/243#issuecomment-1643804290

  • The cover image should be centered. It is probably pressed to the left corner of the corner.
  • Safari Theme Editor did not take into account the Property Grid when filling the background with a picture.
  • backgroundImageAttachment by default it is better to make Fixed
  • Auto works like Tile, which is an important mode for this case. If so, then it's better to rename. Fill mode, which simply stretches the picture is not that useful, but usually it is, although it is possible without it.
@OlgaLarina OlgaLarina transferred this issue from surveyjs/survey-creator Aug 4, 2023
@OlgaLarina
Copy link
Collaborator Author

https://plnkr.co/edit/SsBGDBV9LxbZGBwV

OlgaLarina pushed a commit that referenced this issue Sep 4, 2023
work for #6655
c4cb8af
@OlgaLarina OlgaLarina linked a pull request Sep 4, 2023 that will close this issue
Theme builder: image settings issues #6863
Closed
OlgaLarina pushed a commit that referenced this issue Sep 4, 2023
work for #6655
984311b
OlgaLarina pushed a commit that referenced this issue Sep 4, 2023
work for #6655
772b014
OlgaLarina pushed a commit that referenced this issue Sep 4, 2023
work for #6655
855cfcf
OlgaLarina pushed a commit that referenced this issue Sep 4, 2023
work for #6655 add into other platforms
93becbd
OlgaLarina pushed a commit that referenced this issue Sep 4, 2023
work for #6655 rollback
48f007c
OlgaLarina pushed a commit that referenced this issue Sep 4, 2023
work for #6655 fix
012b294
@OlgaLarina OlgaLarina removed a link to a pull request Sep 4, 2023
Theme builder: image settings issues #6863
Closed
@OlgaLarina OlgaLarina linked a pull request Sep 4, 2023 that will close this issue
survey background image #6864
Merged
OlgaLarina pushed a commit that referenced this issue Sep 26, 2023
work for #6655 fix min height
2e97b97
OlgaLarina pushed a commit that referenced this issue Sep 26, 2023
work for #6655 fix angular template
113b485
OlgaLarina pushed a commit that referenced this issue Sep 27, 2023
work for #6655 remove right: 12px;
b84d599
OlgaLarina pushed a commit that referenced this issue Sep 27, 2023
work for #6655 fix f-test
9802075
OlgaLarina pushed a commit that referenced this issue Sep 27, 2023
work for #6655 fix visual test
8701fcb
tsv2013 pushed a commit that referenced this issue Sep 28, 2023
@OlgaLarina
survey background image (#6864)
53ef380 
* resolve #6654 Survey fit in container

* work for #6655

* work for #6655

* work for #6655

* work for #6655 add into other platforms

* work for #6655 rollback

* work for #6655 fix

* work for #6655 fix min height

* work for #6655 fix angular template

* work for #6655 remove   right: 12px;

* work for #6655 fix f-test

* work for #6655 fix visual test

---------

Co-authored-by: OlgaLarina <[email protected]>
@OlgaLarina OlgaLarina added this to the v1.9.111 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsv2013 tsv2013

@OlgaLarina OlgaLarina

@mikeamelin mikeamelin

@RomanTsukanov RomanTsukanov

Labels
theme builder website demos
Projects
None yet
Milestone
v1.9.111
Development

Successfully merging a pull request may close this issue.

survey background image surveyjs/survey-library
4 participants
@tsv2013 @OlgaLarina @mikeamelin @RomanTsukanov