Add functional tests and fix knockout issue #7748

surveyjs · Jan 26, 2024 · c43b3f8 · c43b3f8
1 parent e266677
commit c43b3f8
Show file tree

Hide file tree

Showing 2 changed files with 71 additions and 2 deletions.
diff --git a/src/knockout/templates/comment.html b/src/knockout/templates/comment.html
@@ -1,7 +1,7 @@
 <script type="text/html" id="survey-comment">
   <!--ko if: !question.isReadOnlyRenderDiv() -->
 <textarea data-bind="attr: { id: question.commentId, maxLength: question.getOthersMaxLength(), 'aria-required': question.ariaRequired || question.a11y_input_ariaRequired, 'aria-label': question.ariaLabel || question.a11y_input_ariaLabel, placeholder: question.renderedCommentPlaceholder }, 
-        event: { input: function(s, e) { $data.question.onCommentInput(s, e); } }, 
+        event: { input: function(s, e) { $data.question.onCommentInput(e); } }, 
         value: $data.question.comment, 
         visible: $data.visible,
         disable: $data.question.isInputReadOnly,
@@ -16,7 +16,7 @@
 <script type="text/html" id="survey-other">
   <!--ko if: !question.isReadOnlyRenderDiv() -->
 <textarea data-bind="attr: { id: question.otherId, maxLength: question.getOthersMaxLength(), 'aria-required': question.ariaRequired || question.a11y_input_ariaRequired, 'aria-label': question.ariaLabel || question.a11y_input_ariaLabel, placeholder: question.otherPlaceholder }, 
-        event: { input: function(s, e) { $data.question.onOtherValueInput(s, e); } }, 
+        event: { input: function(s, e) { $data.question.onOtherValueInput(e); } }, 
         value: $data.question.otherValue, 
         visible: $data.visible,
         disable: $data.question.isInputReadOnly,

diff --git a/testCafe/questions/radiogroup.js b/testCafe/questions/radiogroup.js
@@ -355,4 +355,73 @@ frameworks.forEach(framework => {
     await t
       .expect(Selector(".sv-string-viewer").withText("None").count).eql(1);
   });
+  test("otherItem type in comment, textUpdateMode=onBlur", async t => {
+    const setOnValueChanged = ClientFunction(() => {
+      window["survey"].onValueChanged.add((sender, options) => {
+        if(options.name === "q2") return;
+        const val = sender.getValue("q2");
+        sender.setValue("q2", val + 1);
+      });
+    });
+    const currentJson = {
+      elements: [
+        {
+          type: "radiogroup",
+          showOtherItem: true,
+          name: "q1",
+          choices: [
+            "item1",
+            "item2",
+            "item3"
+          ]
+        },
+        { type: "text", name: "q2", defaultValue: 0, inputType: "number" }
+      ]
+    };
+    await initSurvey(framework, currentJson);
+    await setOnValueChanged();
+
+    await t.click("input[value=other]")
+      .click(Selector("textarea"))
+      .pressKey("A B C D E F tab")
+      .click("input[value=Complete]");
+
+    const surveyResult = await getSurveyResult();
+    assert.deepEqual(surveyResult, { q1: "other", "q1-Comment": "ABCDEF", q2: 2 });
+  });
+  test("otherItem type in comment, textUpdateMode=onTyping", async t => {
+    const setOnValueChanged = ClientFunction(() => {
+      window["survey"].onValueChanged.add((sender, options) => {
+        if(options.name === "q2") return;
+        const val = sender.getValue("q2");
+        sender.setValue("q2", val + 1);
+      });
+    });
+    const currentJson = {
+      textUpdateMode: "onTyping",
+      elements: [
+        {
+          type: "radiogroup",
+          showOtherItem: true,
+          name: "q1",
+          choices: [
+            "item1",
+            "item2",
+            "item3"
+          ]
+        },
+        { type: "text", name: "q2", defaultValue: 0, inputType: "number" }
+      ]
+    };
+    await initSurvey(framework, currentJson);
+    await setOnValueChanged();
+
+    await t.click("input[value=other]")
+      .click(Selector("textarea"))
+      .pressKey("A B C D E F tab")
+      .click("input[value=Complete]");
+
+    const surveyResult = await getSurveyResult();
+    assert.deepEqual(surveyResult, { q1: "other", "q1-Comment": "ABCDEF", q2: 7 });
+  });
 });