work for the #8460

surveyjs · Jun 26, 2024 · 9789cac · 9789cac
1 parent 4ea234c
commit 9789cac
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 6 deletions.
diff --git a/src/question.ts b/src/question.ts
@@ -2674,7 +2674,7 @@ export class Question extends SurveyElement<Question>
   public get a11y_input_ariaRole(): string {
     return null;
   }
-  public get a11y_input_ariaRequired(): "true" | "false" | null {
+  public get a11y_input_ariaRequired(): "true" | "false" {
     return this.isRequired ? "true" : "false";
   }
   public get a11y_input_ariaInvalid(): "true" | "false" {

diff --git a/src/question_checkbox.ts b/src/question_checkbox.ts
@@ -661,7 +661,7 @@ export class QuestionCheckboxModel extends QuestionCheckboxBase {
   public get a11y_input_ariaRole(): string {
     return "group";
   }
-  public get a11y_input_ariaRequired(): "true" | "false" | null {
+  public get a11y_input_ariaRequired(): "true" | "false" {
     return null;
   }
   // EO a11y

diff --git a/tests/markup/helper.ts b/tests/markup/helper.ts
@@ -330,6 +330,8 @@ function clearAttributes(el: Element, removeIds = false) {
   }
   if(el.hasAttribute("readonly"))
     el.setAttribute("readonly", "");
+  if(el.hasAttribute("required"))
+    el.setAttribute("required", "");
   if (el.hasAttribute("disabled"))
     el.setAttribute("disabled", "");
   if(el.hasAttribute("ng-reflect-value")) {

diff --git a/tests/markup/snapshots/matrixdynamic-show-in-multiple-columns-mobile.snap.html b/tests/markup/snapshots/matrixdynamic-show-in-multiple-columns-mobile.snap.html
@@ -53,7 +53,7 @@
 							<legend class="sv-hidden">row row1, column col2</legend>
 							<div class="sd-checkbox sd-checkbox--allowhover sd-item sd-item--allowhover sd-selectbase__item sd-selectbase__item--inline" role="presentation">
 								<label class="sd-selectbase__label">
-									<input class="sd-checkbox__control sd-item__control sd-visuallyhidden" id="testid0row1cell3i_0" name="col2Item 1" required="true" type="checkbox" value="Item 1">
+									<input class="sd-checkbox__control sd-item__control sd-visuallyhidden" id="testid0row1cell3i_0" name="col2Item 1" required="" type="checkbox" value="Item 1">
 									<span class="sd-checkbox__decorator sd-item__decorator">
 										<svg class="sd-checkbox__svg sd-item__svg">
 											<use xlink:href="#icon-v2check" class="">
@@ -67,7 +67,7 @@
 							</div>
 							<div class="sd-checkbox sd-checkbox--allowhover sd-item sd-item--allowhover sd-selectbase__item sd-selectbase__item--inline" role="presentation">
 								<label class="sd-selectbase__label">
-									<input class="sd-checkbox__control sd-item__control sd-visuallyhidden" id="testid0row1cell3i_1" name="col2Item 2" required="true" type="checkbox" value="Item 2">
+									<input class="sd-checkbox__control sd-item__control sd-visuallyhidden" id="testid0row1cell3i_1" name="col2Item 2" required="" type="checkbox" value="Item 2">
 									<span class="sd-checkbox__decorator sd-item__decorator">
 										<svg class="sd-checkbox__svg sd-item__svg">
 											<use xlink:href="#icon-v2check" class="">

diff --git a/tests/markup/snapshots/matrixdynamic-show-in-multiple-columns.snap.html b/tests/markup/snapshots/matrixdynamic-show-in-multiple-columns.snap.html
@@ -35,7 +35,7 @@
 					<div class="sd-table__question-wrapper">
 						<div class="sd-checkbox sd-checkbox--allowhover sd-item sd-item--allowhover sd-selectbase__item sd-selectbase__item--inline" role="presentation">
 							<label class="sd-selectbase__label">
-								<input class="sd-checkbox__control sd-item__control sd-visuallyhidden" id="testid0row1cell3i_0" name="col2Item 1" required="true" type="checkbox" value="Item 1">
+								<input class="sd-checkbox__control sd-item__control sd-visuallyhidden" id="testid0row1cell3i_0" name="col2Item 1" required="" type="checkbox" value="Item 1">
 								<span class="sd-checkbox__decorator sd-item__decorator">
 									<svg class="sd-checkbox__svg sd-item__svg">
 										<use xlink:href="#icon-v2check" class="">
@@ -50,7 +50,7 @@
 					<div class="sd-table__question-wrapper">
 						<div class="sd-checkbox sd-checkbox--allowhover sd-item sd-item--allowhover sd-selectbase__item sd-selectbase__item--inline" role="presentation">
 							<label class="sd-selectbase__label">
-								<input class="sd-checkbox__control sd-item__control sd-visuallyhidden" id="testid0row1cell3i_1" name="col2Item 2" required="true" type="checkbox" value="Item 2">
+								<input class="sd-checkbox__control sd-item__control sd-visuallyhidden" id="testid0row1cell3i_1" name="col2Item 2" required="" type="checkbox" value="Item 2">
 								<span class="sd-checkbox__decorator sd-item__decorator">
 									<svg class="sd-checkbox__svg sd-item__svg">
 										<use xlink:href="#icon-v2check" class="">