Merge pull request #6778 from surveyjs/bug/service-1346-ranking-at-cr…

…eator-landing PR: Survey Creator landing: Drag and drop doesn't work
surveyjs · Aug 25, 2023 · 80f051d · 80f051d
2 parents ded3f88 + b3e1d2f
commit 80f051d
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 2 deletions.
diff --git a/src/dragdrop/core.ts b/src/dragdrop/core.ts
@@ -113,9 +113,12 @@ export abstract class DragDropCore<T> implements IDragDropEngine {
   protected doBanDropHere = (): void => { };
 
   protected findDropTargetNodeFromPoint(clientX: number, clientY: number): HTMLElement {
-    this.domAdapter.draggedElementShortcut.hidden = true;
+    const displayProp = this.domAdapter.draggedElementShortcut.style.display;
+    //this.domAdapter.draggedElementShortcut.hidden = true;
+    this.domAdapter.draggedElementShortcut.style.display = "none";
     let dragOverNode = <HTMLElement>document.elementFromPoint(clientX, clientY);
-    this.domAdapter.draggedElementShortcut.hidden = false;
+    // this.domAdapter.draggedElementShortcut.hidden = false;
+    this.domAdapter.draggedElementShortcut.style.display = displayProp || "block";
 
     if (!dragOverNode) return null;
 

diff --git a/testCafe/questions/ranking.js b/testCafe/questions/ranking.js
@@ -281,4 +281,32 @@ frameworks.forEach((framework) => {
       "one"
     ]);
   });
+
+  test("ranking: work with flexbox layout", async (t) => {
+    const addFlexboxLayout = ClientFunction(() => {
+      const stylesheet = document.styleSheets[0];
+      stylesheet.addRule(".sv-ranking.sv-ranking.sv-ranking.sv-ranking.sv-ranking", "display:flex;flex-direction: column", 0);
+    });
+    const removeFlexboxLayout = ClientFunction(() => {
+      const stylesheet = document.styleSheets[0];
+      stylesheet.removeRule(0);
+    });
+
+    await addFlexboxLayout();
+
+    await t.dragToElement(PriceItem, BatteryItem);
+
+    let data = await getData();
+    await t.expect(data["smartphone-features"]).eql([
+      "Price",
+      "Battery life",
+      "Screen size",
+      "Storage space",
+      "Camera quality",
+      "Durability",
+      "Processor power",
+    ]);
+
+    await removeFlexboxLayout();
+  });
 });