work for the #7884 (#7896)

surveyjs · Feb 22, 2024 · 7c6b930 · 7c6b930
1 parent 8e39f30
commit 7c6b930
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/dragdrop/ranking-select-to-rank.ts b/src/dragdrop/ranking-select-to-rank.ts
@@ -93,7 +93,10 @@ export class DragDropRankingSelectToRank extends DragDropRankingChoices {
     let fromIndex = fromChoicesArray.indexOf(this.draggedElement);
     let toIndex = toChoicesArray.indexOf(this.dropTarget);
 
-    if (toIndex === -1) toIndex = model.value.length;
+    if (toIndex === -1) {
+      const length = model.value.length;
+      toIndex = fromChoicesArray === toChoicesArray ? length - 1 : length;
+    }
 
     return { fromIndex, toIndex };
   }

diff --git a/tests/dragdrophelpertests.ts b/tests/dragdrophelpertests.ts
@@ -309,8 +309,10 @@ QUnit.test("DragDropRankingSelectToRank getIndixies", function (assert) {
   const dndModel = new DragDropRankingSelectToRank();
   const questionModel = createRankingQuestionModel(withDefaultValue);
 
-  let { toIndex } = dndModel.getIndixies(questionModel, questionModel.rankingChoices, questionModel.unRankingChoices);
+  let toIndex = dndModel.getIndixies(questionModel, questionModel.rankingChoices, questionModel.unRankingChoices).toIndex;
   assert.equal(toIndex, 2);
+  toIndex = dndModel.getIndixies(questionModel, questionModel.rankingChoices, questionModel.rankingChoices).toIndex;
+  assert.equal(toIndex, 1);
 });
 // EO selectToRankEnabled