#6642 - add some tests and fix etalons

surveyjs · Aug 12, 2023 · 788f506 · 788f506
1 parent 0cbdcfe
commit 788f506
Show file tree

Hide file tree

Showing 24 changed files with 271 additions and 2 deletions.
diff --git a/src/defaultV2-theme/blocks/sd-table.scss b/src/defaultV2-theme/blocks/sd-table.scss
@@ -15,11 +15,11 @@
   border-bottom: calcSize(1) solid transparent;
   background-clip: padding-box;
 }
-.sd-table__row:first-child>.sd-table__cell:not(.sd-question--error) {
+.sd-table__row:first-child>.sd-table__cell {
   border-top: 0;
 }
 
-.sd-table__row:last-child>.sd-table__cell:not(.sd-question--error) {
+.sd-table__row:last-child>.sd-table__cell {
   border-bottom: 0;
 }
 

diff --git a/...RegressionTests/tests/defaultV2/etalons/matrixdynamic-errors-in-cell-bottom.png b/...RegressionTests/tests/defaultV2/etalons/matrixdynamic-errors-in-cell-bottom.png
diff --git a/visualRegressionTests/tests/defaultV2/etalons/matrixdynamic-errors-in-cell.png b/visualRegressionTests/tests/defaultV2/etalons/matrixdynamic-errors-in-cell.png
diff --git a/...essionTests/tests/defaultV2/etalons/question-matrix-columns-rows-width_diff.png b/...essionTests/tests/defaultV2/etalons/question-matrix-columns-rows-width_diff.png
diff --git a/...sionTests/tests/defaultV2/etalons/question-matrix-columns-rows-width_etalon.png b/...sionTests/tests/defaultV2/etalons/question-matrix-columns-rows-width_etalon.png
diff --git a/...essionTests/tests/defaultV2/etalons/question-matrix-columns-rows-width_mask.png b/...essionTests/tests/defaultV2/etalons/question-matrix-columns-rows-width_mask.png
diff --git a/...essionTests/tests/defaultV2/etalons/question-matrix-dynamic-detail-expanded.png b/...essionTests/tests/defaultV2/etalons/question-matrix-dynamic-detail-expanded.png
diff --git a/visualRegressionTests/tests/defaultV2/etalons/question-matrix-dynamic-detail.png b/visualRegressionTests/tests/defaultV2/etalons/question-matrix-dynamic-detail.png
diff --git a/...ionTests/tests/defaultV2/etalons/question-matrix-dynamic-no-header-no-title.png b/...ionTests/tests/defaultV2/etalons/question-matrix-dynamic-no-header-no-title.png
diff --git a/...alRegressionTests/tests/defaultV2/etalons/question-matrix-dynamic-no-header.png b/...alRegressionTests/tests/defaultV2/etalons/question-matrix-dynamic-no-header.png
diff --git a/visualRegressionTests/tests/defaultV2/etalons/question-matrix-dynamic-no-title.png b/visualRegressionTests/tests/defaultV2/etalons/question-matrix-dynamic-no-title.png
diff --git a/visualRegressionTests/tests/defaultV2/etalons/question-matrix-dynamic.png b/visualRegressionTests/tests/defaultV2/etalons/question-matrix-dynamic.png
diff --git a/...sts/tests/defaultV2/etalons/question-matrix-multi-select-no-header-no-title.png b/...sts/tests/defaultV2/etalons/question-matrix-multi-select-no-header-no-title.png
diff --git a/...ressionTests/tests/defaultV2/etalons/question-matrix-multi-select-no-header.png b/...ressionTests/tests/defaultV2/etalons/question-matrix-multi-select-no-header.png
diff --git a/...gressionTests/tests/defaultV2/etalons/question-matrix-multi-select-no-title.png b/...gressionTests/tests/defaultV2/etalons/question-matrix-multi-select-no-title.png
diff --git a/visualRegressionTests/tests/defaultV2/etalons/question-matrix-multi-select.png b/visualRegressionTests/tests/defaultV2/etalons/question-matrix-multi-select.png
diff --git a/...ts/tests/defaultV2/etalons/question-matrix-single-select-alt-rows-no-header.png b/...ts/tests/defaultV2/etalons/question-matrix-single-select-alt-rows-no-header.png
diff --git a/...ressionTests/tests/defaultV2/etalons/question-matrix-single-select-alt-rows.png b/...ressionTests/tests/defaultV2/etalons/question-matrix-single-select-alt-rows.png
diff --git a/...essionTests/tests/defaultV2/etalons/question-matrix-single-select-no-header.png b/...essionTests/tests/defaultV2/etalons/question-matrix-single-select-no-header.png
diff --git a/visualRegressionTests/tests/defaultV2/etalons/question-matrix-single-select.png b/visualRegressionTests/tests/defaultV2/etalons/question-matrix-single-select.png
diff --git a/...ests/tests/defaultV2/etalons/question-rating-stars-small-focus-hovered_mask.png b/...ests/tests/defaultV2/etalons/question-rating-stars-small-focus-hovered_mask.png
diff --git a/...sts/tests/defaultV2/etalons/question-rating-stars-small-focus-selected_mask.png b/...sts/tests/defaultV2/etalons/question-rating-stars-small-focus-selected_mask.png
diff --git a/...ressionTests/tests/defaultV2/etalons/question-rating-stars-small-focus_mask.png b/...ressionTests/tests/defaultV2/etalons/question-rating-stars-small-focus_mask.png
diff --git a/visualRegressionTests/tests/defaultV2/matrix.ts b/visualRegressionTests/tests/defaultV2/matrix.ts
@@ -19,6 +19,275 @@ frameworks.forEach(framework => {
     await explicitErrorHandler();
     await applyTheme(theme);
   });
+
+  test("Matrix single-select", async (t) => {
+    await wrapVisualTest(t, async (t, comparer) => {
+      await t.resizeWindow(1200, 1200);
+      await initSurvey(framework, {
+        "logoPosition": "right",
+        "pages": [
+          {
+            "name": "page1",
+            "elements": [
+              {
+                "type": "matrix",
+                "name": "q",
+                "title": "Question",
+                "alternateRows": true,
+                "columns": [
+                  {
+                    "value": "Column 1",
+                    "text": "Title"
+                  },
+                  {
+                    "value": "Column 2",
+                    "text": "Title"
+                  },
+                  {
+                    "value": "Column 3",
+                    "text": "Title"
+                  }
+                ],
+                "rows": [
+                  {
+                    "value": "Row 1",
+                    "text": "Title"
+                  },
+                  {
+                    "value": "Row 2",
+                    "text": "Title"
+                  },
+                  {
+                    "value": "Row 3",
+                    "text": "Title"
+                  }
+                ]
+              }
+            ]
+          }
+        ],
+        "showQuestionNumbers": "off",
+        "widthMode": "static",
+        "width": "720px"
+      });
+
+      const questionRoot = Selector(".sd-row");
+      await takeElementScreenshot("question-matrix-single-select-alt-rows.png", questionRoot, t, comparer);
+
+      await ClientFunction(() => { window["survey"].getQuestionByName("q").showHeader = false; })();
+      await takeElementScreenshot("question-matrix-single-select-alt-rows-no-header.png", questionRoot, t, comparer);
+
+      await ClientFunction(() => { window["survey"].getQuestionByName("q").alternateRows = false; })();
+      await takeElementScreenshot("question-matrix-single-select-no-header.png", questionRoot, t, comparer);
+
+      await ClientFunction(() => { window["survey"].getQuestionByName("q").showHeader = false; })();
+      await takeElementScreenshot("question-matrix-single-select.png", questionRoot, t, comparer);
+    });
+  });
+
+  test("Matrix multi-select", async (t) => {
+    await wrapVisualTest(t, async (t, comparer) => {
+      await t.resizeWindow(1200, 1200);
+      await initSurvey(framework, {
+        "logoPosition": "right",
+        "pages": [
+          {
+            "name": "page1",
+            "elements": [
+              {
+                "type": "matrixdropdown",
+                "name": "q",
+                "title": "Question",
+                "columns": [
+                  {
+                    "name": "Column 1",
+                    "title": "Title"
+                  },
+                  {
+                    "name": "Column 2",
+                    "title": "Title"
+                  },
+                  {
+                    "name": "Column 3",
+                    "title": "Title"
+                  }
+                ],
+                "choices": [
+                  1,
+                  2,
+                  3,
+                  4,
+                  5
+                ],
+                "cellType": "text",
+                "rows": [
+                  {
+                    "value": "Row 1",
+                    "text": "Title"
+                  },
+                  {
+                    "value": "Row 2",
+                    "text": "Title"
+                  },
+                  {
+                    "value": "Row 3",
+                    "text": "Title"
+                  }
+                ]
+              }
+            ]
+          }
+        ],
+        "showQuestionNumbers": "off",
+        "widthMode": "static",
+        "width": "720px"
+      });
+
+      const questionRoot = Selector(".sd-row");
+      await takeElementScreenshot("question-matrix-multi-select.png", questionRoot, t, comparer);
+
+      await ClientFunction(() => { window["survey"].getQuestionByName("q").showHeader = false; })();
+      await takeElementScreenshot("question-matrix-multi-select-no-header.png", questionRoot, t, comparer);
+
+      await ClientFunction(() => { window["survey"].getQuestionByName("q").titleLocation = "hidden"; })();
+      await takeElementScreenshot("question-matrix-multi-select-no-header-no-title.png", questionRoot, t, comparer);
+
+      await ClientFunction(() => { window["survey"].getQuestionByName("q").showHeader = true; })();
+      await takeElementScreenshot("question-matrix-multi-select-no-title.png", questionRoot, t, comparer);
+    });
+  });
+
+  test("Matrix dynamic", async (t) => {
+    await wrapVisualTest(t, async (t, comparer) => {
+      await t.resizeWindow(1200, 1200);
+      await initSurvey(framework, {
+        "logoPosition": "right",
+        "pages": [
+          {
+            "name": "page1",
+            "elements": [
+              {
+                "type": "matrixdynamic",
+                "name": "q",
+                "title": "Question",
+                "columns": [
+                  {
+                    "name": "Column 1",
+                    "title": "Title"
+                  },
+                  {
+                    "name": "Column 2",
+                    "title": "Title"
+                  },
+                  {
+                    "name": "Column 3",
+                    "title": "Title"
+                  }
+                ],
+                "choices": [
+                  1,
+                  2,
+                  3,
+                  4,
+                  5
+                ],
+                "cellType": "text",
+                "rowCount": 3
+              }
+            ]
+          }
+        ],
+        "showQuestionNumbers": "off",
+        "widthMode": "static",
+        "width": "720px"
+      });
+
+      const questionRoot = Selector(".sd-row");
+      await takeElementScreenshot("question-matrix-dynamic.png", questionRoot, t, comparer);
+
+      await ClientFunction(() => { window["survey"].getQuestionByName("q").showHeader = false; })();
+      await takeElementScreenshot("question-matrix-dynamic-no-header.png", questionRoot, t, comparer);
+
+      await ClientFunction(() => { window["survey"].getQuestionByName("q").titleLocation = "hidden"; })();
+      await takeElementScreenshot("question-matrix-dynamic-no-header-no-title.png", questionRoot, t, comparer);
+
+      await ClientFunction(() => { window["survey"].getQuestionByName("q").showHeader = true; })();
+      await takeElementScreenshot("question-matrix-dynamic-no-title.png", questionRoot, t, comparer);
+    });
+  });
+
+  test("Matrix dynamic detail", async (t) => {
+    await wrapVisualTest(t, async (t, comparer) => {
+      await t.resizeWindow(1200, 1200);
+      await initSurvey(framework, {
+        "logoPosition": "right",
+        "pages": [
+          {
+            "name": "page1",
+            "elements": [
+              {
+                "type": "matrixdynamic",
+                "name": "q",
+                "title": "Question",
+                "columns": [
+                  {
+                    "name": "Column 1",
+                    "title": "Title"
+                  },
+                  {
+                    "name": "Column 2",
+                    "title": "Title"
+                  },
+                  {
+                    "name": "Column 3",
+                    "title": "Title"
+                  }
+                ],
+                "detailElements": [
+                  {
+                    "type": "text",
+                    "name": "question1",
+                    "titleLocation": "hidden"
+                  },
+                  {
+                    "type": "text",
+                    "name": "question2",
+                    "titleLocation": "hidden"
+                  },
+                  {
+                    "type": "text",
+                    "name": "question3",
+                    "titleLocation": "hidden"
+                  }
+                ],
+                "detailPanelMode": "underRow",
+                "choices": [
+                  1,
+                  2,
+                  3,
+                  4,
+                  5
+                ],
+                "cellType": "text",
+                "rowCount": 3
+              }
+            ]
+          }
+        ],
+        "showQuestionNumbers": "off",
+        "widthMode": "static",
+        "width": "720px"
+      });
+
+      const questionRoot = Selector(".sd-row");
+      await takeElementScreenshot("question-matrix-dynamic-detail.png", questionRoot, t, comparer);
+      await t.click(Selector(".sd-table__cell--detail-button").filterVisible().nth(1));
+
+      await takeElementScreenshot("question-matrix-dynamic-detail-expanded.png", questionRoot, t, comparer);
+
+    });
+  });
+
   test("Matrix dropdown", async (t) => {
     await wrapVisualTest(t, async (t, comparer) => {
       await t.resizeWindow(800, 600);