goNextPageAutomatic and showOtherItem are not working well together fix

#7681
surveyjs · Jan 16, 2024 · 69224cc · 69224cc
1 parent 34effef
commit 69224cc
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/src/question_dropdown.ts b/src/question_dropdown.ts
@@ -99,7 +99,7 @@ export class QuestionDropdownModel extends QuestionSelectBase {
     }
   }
   supportGoNextPageAutomatic(): boolean {
-    return true;
+    return !this.isOtherSelected;
   }
   private minMaxChoices = <Array<ItemValue>>[];
   protected getChoices(): Array<ItemValue> {

diff --git a/src/question_radiogroup.ts b/src/question_radiogroup.ts
@@ -47,7 +47,7 @@ export class QuestionRadiogroupModel extends QuestionCheckboxBase {
     return this.getLocalizationString("clearCaption");
   }
   supportGoNextPageAutomatic(): boolean {
-    return this.isMouseDown === true;
+    return this.isMouseDown === true && !this.isOtherSelected;
   }
   protected setNewComment(newValue: string): void {
     this.isMouseDown = true;

diff --git a/tests/surveyquestiontests.ts b/tests/surveyquestiontests.ts
@@ -849,11 +849,14 @@ QUnit.test("Radiogroup Question: support goNextPageAutomatic + hasOther", functi
     goNextPageAutomatic: true,
   };
   const survey = new SurveyModel(json);
-  const question = survey.getQuestionByName("q1");
+  const question = <QuestionRadiogroupModel>survey.getQuestionByName("q1");
   question.value = "other";
   assert.equal(survey.currentPageNo, 0, "Stay on the first page");
   question.comment = "123";
-  assert.equal(survey.currentPageNo, 1, "Go to the second page");
+  assert.equal(survey.currentPageNo, 0, "Still stay on the page");
+  question.onMouseDown();
+  question.value = 2;
+  assert.equal(survey.currentPageNo, 1, "Go to the next page");
 });
 
 QUnit.test(

diff --git a/tests/surveytests.ts b/tests/surveytests.ts
@@ -1673,6 +1673,8 @@ QUnit.test("Should not show errors with others bug #2014", function (assert) {
   assert.equal(survey.currentPageNo, 0, "The page is still first");
   assert.equal(question.errors.length, 0, "Do not show any error");
   question.comment = "Some text";
+  assert.equal(survey.currentPageNo, 0, "The page is still first, #2");
+  question.value = 2;
   assert.equal(survey.currentPageNo, 1, "The second page is shown");
 });
 QUnit.test(
@@ -3906,6 +3908,8 @@ QUnit.test("test goNextPageAutomatic property", function (assert) {
   );
   assert.notEqual(survey.state, "completed", "survey is still running");
   dropDownQ.comment = "other value";
+  assert.notEqual(survey.state, "completed", "survey is still running #2");
+  dropDownQ.value = 1;
   assert.equal(survey.state, "completed", "complete the survey");
 });
 QUnit.test("test goNextPageAutomatic property for boolean/switch", function (