#7564 Matrix question has rows of different height in alternate rows …

…mode (#7637) * #7564 Matrix question has rows of different height in alternate rows mode Fixes #7564 * #7564 - update screenshots and fix styles * #7564 - update matrix runbric alternate rows screenshot
surveyjs · Jan 11, 2024 · 5b79199 · 5b79199
1 parent 4ab37ec
commit 5b79199
Show file tree

Hide file tree

Showing 11 changed files with 10 additions and 1 deletion.
diff --git a/src/defaultV2-theme/blocks/sd-table.scss b/src/defaultV2-theme/blocks/sd-table.scss
@@ -107,10 +107,19 @@
       padding-right: calcSize(2);
     }
 
+    .sd-table__row:first-of-type>.sd-table__cell {
+      border-top: calcSize(1) solid transparent;
+    }
+    .sd-table__row:last-of-type>.sd-table__cell {
+      border-bottom: calcSize(1) solid transparent;
+    }
+
     .sd-table__row:nth-of-type(odd) {
 
-      &>td,
+      &>td.sd-table__cell,
       td:first-of-type {
+        border-top-color: $background-dim-light;
+        border-bottom-color: $background-dim-light;
         background-color: $background-dim-light;
 
         &.sd-matrix__text--checked {

diff --git a/...nTests/tests/defaultV2/etalons/question-matrix-alternate-rows-invalid-value.png b/...nTests/tests/defaultV2/etalons/question-matrix-alternate-rows-invalid-value.png
diff --git a/...Tests/tests/defaultV2/etalons/question-matrix-alternate-rows-selected-value.png b/...Tests/tests/defaultV2/etalons/question-matrix-alternate-rows-selected-value.png
diff --git a/visualRegressionTests/tests/defaultV2/etalons/question-matrix-alternate-rows.png b/visualRegressionTests/tests/defaultV2/etalons/question-matrix-alternate-rows.png
diff --git a/...gressionTests/tests/defaultV2/etalons/question-matrix-rubric-alternate-rows.png b/...gressionTests/tests/defaultV2/etalons/question-matrix-rubric-alternate-rows.png
diff --git a/...ts/tests/defaultV2/etalons/question-matrix-single-select-alt-rows-no-header.png b/...ts/tests/defaultV2/etalons/question-matrix-single-select-alt-rows-no-header.png
diff --git a/...ressionTests/tests/defaultV2/etalons/question-matrix-single-select-alt-rows.png b/...ressionTests/tests/defaultV2/etalons/question-matrix-single-select-alt-rows.png
diff --git a/...defaultV2/etalons/question-matrix-single-select-in-panel-no-header-no-title.png b/...defaultV2/etalons/question-matrix-single-select-in-panel-no-header-no-title.png
diff --git a/...ts/tests/defaultV2/etalons/question-matrix-single-select-in-panel-no-header.png b/...ts/tests/defaultV2/etalons/question-matrix-single-select-in-panel-no-header.png
diff --git a/...sts/tests/defaultV2/etalons/question-matrix-single-select-in-panel-no-title.png b/...sts/tests/defaultV2/etalons/question-matrix-single-select-in-panel-no-title.png
diff --git a/...ressionTests/tests/defaultV2/etalons/question-matrix-single-select-in-panel.png b/...ressionTests/tests/defaultV2/etalons/question-matrix-single-select-in-panel.png