Fixed duplicated file uploads

surveyjs · Feb 9, 2024 · 43360d4 · 43360d4
1 parent 4ab9812
commit 43360d4
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 8 deletions.
diff --git a/packages/survey-angular-ui/src/questions/file.component.html b/packages/survey-angular-ui/src/questions/file.component.html
@@ -1,6 +1,6 @@
 <div [class]="model.fileRootCss" #contentElement>
   <input [class]="model.cssClasses.fileInput" *ngIf="!model.isReadOnly && model.hasFileUI" tabindex="-1" type="file"
-    [attr.id]="model.inputId" (change)="model.doChange($event)" [attr.aria-required]="model.ariaRequired"
+    [attr.id]="model.inputId" [attr.aria-required]="model.ariaRequired"
     [attr.aria-label]="model.ariaLabel" [attr.aria-invalid]="model.ariaInvalid"
     [attr.aria-describedby]="model.ariaDescribedBy" [attr.multiple]="model.multipleRendered"
     [attr.title]="model.inputTitle" [attr.accept]="model.acceptedTypes" [attr.capture]="model.renderCapture" />

diff --git a/packages/survey-vue3-ui/src/File.vue b/packages/survey-vue3-ui/src/File.vue
@@ -6,7 +6,6 @@
       tabindex="-1"
       type="file"
       :id="question.inputId"
-      @change="question.doChange"
       :aria-required="question.ariaRequired"
       :aria-label="question.ariaLabel"
       :aria-invalid="question.ariaInvalid"

diff --git a/src/knockout/templates/question-file.html b/src/knockout/templates/question-file.html
@@ -2,7 +2,7 @@
   <div data-bind="css: question.fileRootCss">
         <!-- ko ifnot: question.isInputReadOnly -->
           <!-- ko if: question.hasFileUI -->
-          <input type="file" tabindex="-1" data-bind="css: question.cssClasses.fileInput, attr: { id: question.inputId, 'aria-required': question.ariaRequired, 'aria-label': question.ariaLabel, 'aria-invalid': question.ariaInvalid, 'aria-describedby': question.ariaDescribedBy, multiple: question.allowMultiple ? 'multiple' : undefined, title: koInputTitle, accept: question.acceptedTypes, capture: question.renderCapture }, event: { change: question.dochange }">
+          <input type="file" tabindex="-1" data-bind="css: question.cssClasses.fileInput, attr: { id: question.inputId, 'aria-required': question.ariaRequired, 'aria-label': question.ariaLabel, 'aria-invalid': question.ariaInvalid, 'aria-describedby': question.ariaDescribedBy, multiple: question.allowMultiple ? 'multiple' : undefined, title: koInputTitle, accept: question.acceptedTypes, capture: question.renderCapture }">
           <!-- /ko -->
         <!-- /ko -->
         <!-- ko if: question.isReadOnly -->

diff --git a/src/question_file.ts b/src/question_file.ts
@@ -1017,8 +1017,8 @@ export class QuestionFileModel extends QuestionFileModelBase {
     }
   }
   doChange = (event: any) => {
-    // var src = event.target || event.srcElement;
-    // this.onChange(src);
+    var src = event.target || event.srcElement;
+    this.onChange(src);
   }
   doClean = () => {
     if (this.needConfirmRemoveFile) {

diff --git a/src/react/reactquestion_file.tsx b/src/react/reactquestion_file.tsx
@@ -37,7 +37,6 @@ export class SurveyQuestionFile extends SurveyQuestionElementBase {
           id={this.question.inputId}
           ref={input => (this.setControl(input))}
           style={!this.isDisplayMode ? {} : { color: "transparent" }}
-          onChange={!this.isDisplayMode ? this.question.doChange : (() => {})}
           multiple={this.question.allowMultiple}
           placeholder={this.question.title}
           accept={this.question.acceptedTypes}
@@ -50,7 +49,6 @@ export class SurveyQuestionFile extends SurveyQuestionElementBase {
             id={this.question.inputId}
             ref={input => (this.setControl(input))}
             style={!this.isDisplayMode ? {} : { color: "transparent" }}
-            onChange={!this.isDisplayMode ? this.question.doChange : (() => {})}
             aria-required={this.question.ariaRequired}
             aria-label={this.question.ariaLabel}
             aria-invalid={this.question.ariaInvalid}

diff --git a/src/vue/file.vue b/src/vue/file.vue
@@ -6,7 +6,6 @@
       tabindex="-1"
       type="file"
       :id="question.inputId"
-      @change="question.doChange"
       :aria-required="question.ariaRequired"
       :aria-label="question.ariaLabel"
       :aria-invalid="question.ariaInvalid"