Remove focus stopPropagation in action items

surveyjs · Jul 8, 2024 · 3318b5e · 3318b5e
1 parent 95709ea
commit 3318b5e
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 17 deletions.
diff --git a/packages/survey-angular-ui/src/utils/ng-key2click.directive.ts b/packages/survey-angular-ui/src/utils/ng-key2click.directive.ts
@@ -23,9 +23,6 @@ export class Key2ClickDirective implements OnChanges, OnDestroy {
   private blur (evt: any) {
     doKey2ClickBlur(evt);
   }
-  private focus (evt: any) {
-    evt.stopPropagation();
-  }
   constructor(private el: ElementRef) {
     this.subscribeEventListeners();
   }
@@ -41,7 +38,6 @@ export class Key2ClickDirective implements OnChanges, OnDestroy {
     this.element.addEventListener("keyup", this.onkeyup.bind(this));
     this.element.addEventListener("keydown", this.onkeydown.bind(this));
     this.element.addEventListener("blur", this.blur);
-    this.element.addEventListener("focus", this.focus);
 
     this.isSubscribed = true;
   }
@@ -52,7 +48,6 @@ export class Key2ClickDirective implements OnChanges, OnDestroy {
     this.element.removeEventListener("keyup", this.onkeyup.bind(this));
     this.element.removeEventListener("keydown", this.onkeydown.bind(this));
     this.element.removeEventListener("blur", this.blur);
-    this.element.removeEventListener("focus", this.focus);
 
     this.isSubscribed = false;
   }

diff --git a/packages/survey-vue3-ui/src/components/action-bar/ActionBarItem.vue b/packages/survey-vue3-ui/src/components/action-bar/ActionBarItem.vue
@@ -12,11 +12,6 @@
         evt.stopPropagation();
       }
     "
-    v-on:focus="
-      (evt) => {
-        evt.stopPropagation();
-      }
-    "
     v-bind:disabled="item.disabled"
     v-bind:title="item.tooltip || item.title"
     v-bind:aria-checked="item.ariaChecked"

diff --git a/src/knockout/kosurvey.ts b/src/knockout/kosurvey.ts
@@ -320,6 +320,5 @@ ko.bindingHandlers["key2click"] = {
     };
     element.onkeydown = (evt: any) => doKey2ClickDown(evt, options);
     element.onblur = (evt: any) => doKey2ClickBlur(evt);
-    element.onfocus = (evt: any) => evt.stopPropagation();
   },
 };
diff --git a/src/react/reactSurvey.tsx b/src/react/reactSurvey.tsx
@@ -320,7 +320,6 @@ export function attachKey2click(element: JSX.Element, viewModel?: any, options:
       },
       onKeyDown: (evt: any) => doKey2ClickDown(evt, options),
       onBlur: (evt: any) => doKey2ClickBlur(evt),
-      onFocus: (evt: any) => evt.stopPropagation()
     }
   );
 }
diff --git a/src/vue/components/action-bar/action-bar-item.vue b/src/vue/components/action-bar/action-bar-item.vue
@@ -12,11 +12,6 @@
         evt.stopPropagation();
       }
     "
-    v-on:focus="
-      (evt) => {
-        evt.stopPropagation();
-      }
-    "
     v-bind:disabled="item.disabled"
     v-bind:title="item.tooltip || item.title"
     v-bind:aria-checked="item.ariaChecked"