ICustomQuestionTypeConfiguration: Rename onSetQuestionValue to onValu…

…eSet add it to the docs fix #8321
surveyjs · Jun 26, 2024 · 070b8bb · 070b8bb
1 parent c8065bb
commit 070b8bb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/question_custom.ts b/src/question_custom.ts
@@ -252,6 +252,7 @@ export interface ICustomQuestionTypeConfiguration {
    * @returns An error text.
    */
   getErrorText?: (question: Question) => string;
+  onValueSet?: (question: Question, newValue: any) => void;
   onSetQuestionValue?: (question: Question, newValue: any) => void;
   valueToQuestion?: (val: any) => any;
   valueFromQuestion?: (val: any) => any;
@@ -305,8 +306,12 @@ export class ComponentQuestionJSON {
     this.json.onUpdateQuestionCssClasses(question, element, css);
   }
   public onSetQuestionValue(question: Question, newValue: any): void {
-    if (!this.json.onSetQuestionValue) return;
-    this.json.onSetQuestionValue(question, newValue);
+    if (this.json.onSetQuestionValue) {
+      this.json.onSetQuestionValue(question, newValue);
+    }
+    if (this.json.onValueSet) {
+      this.json.onValueSet(question, newValue);
+    }
   }
   public onPropertyChanged(
     question: Question,

diff --git a/tests/question_customtests.ts b/tests/question_customtests.ts
@@ -3118,7 +3118,7 @@ QUnit.test("Composite: update questions on a value change", function (assert) {
       { type: "dropdown", name: "q2" },
       { type: "text", name: "q3" }
     ],
-    onSetQuestionValue: (question, newValue: any): void => {
+    onValueSet: (question, newValue: any): void => {
       if(!!newValue && !!newValue.q3) {
         question.contentPanel.getQuestionByName("q2").choices = [newValue.q3];
       }