Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creator settings: refactoring font styles #5968

Merged
merged 58 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
a3790e8
work for https://github.com/surveyjs/private-tasks/issues/382
Sep 25, 2024
519c654
Merge branch 'master' of github.com:surveyjs/survey-creator into issu…
Sep 30, 2024
8ad1de2
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 1, 2024
76c46ec
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 1, 2024
873e527
Merge branch 'issue/Creator-Settings' of github.com:surveyjs/survey-c…
Oct 2, 2024
226847c
Merge branch 'master' of github.com:surveyjs/survey-creator into issu…
Oct 2, 2024
d3ce95a
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 2, 2024
11413cd
Merge branch 'master' of github.com:surveyjs/survey-creator into issu…
Oct 2, 2024
df84274
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 2, 2024
2a6581f
work for https://github.com/surveyjs/private-tasks/issues/382 - add t…
Oct 7, 2024
af1af3d
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 7, 2024
360c5a7
Merge branch 'master' of github.com:surveyjs/survey-creator into issu…
Oct 7, 2024
69fd197
work for https://github.com/surveyjs/private-tasks/issues/38 add used…
Oct 8, 2024
decb64d
work for https://github.com/surveyjs/private-tasks/issues/382 - ko fi…
Oct 8, 2024
f5579fe
Merge branch 'master' of github.com:surveyjs/survey-creator into issu…
Oct 8, 2024
0895bb5
work for https://github.com/surveyjs/private-tasks/issues/382 - refac…
Oct 8, 2024
8d18378
work for https://github.com/surveyjs/private-tasks/issues/382 - extra…
Oct 8, 2024
5e2d187
Merge branch 'master' of github.com:surveyjs/survey-creator into issu…
Oct 8, 2024
140ed36
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 8, 2024
1fd4b6e
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 8, 2024
6e6abfd
Merge branch 'master' of github.com:surveyjs/survey-creator into issu…
Oct 9, 2024
a700e64
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 10, 2024
56cfb8b
Merge branch 'master' of github.com:surveyjs/survey-creator into issu…
Oct 10, 2024
2400eca
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 11, 2024
e1b18f4
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 11, 2024
0592f3b
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 15, 2024
06d93f6
Merge branch 'master' of github.com:surveyjs/survey-creator into issu…
Oct 15, 2024
9e06cdb
work for https://github.com/surveyjs/private-tasks/issues/382 update …
Oct 15, 2024
c471980
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 15, 2024
034bf00
Merge branch 'issue/Creator-Settings' of github.com:surveyjs/survey-c…
Oct 15, 2024
d0995ab
work for https://github.com/surveyjs/private-tasks/issues/382 update …
Oct 16, 2024
943c9b5
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 16, 2024
fe94dfc
work for https://github.com/surveyjs/private-tasks/issues/382 fix
Oct 16, 2024
1e9a31b
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 16, 2024
593ddd5
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 17, 2024
f258b7a
Merge branch 'master' of github.com:surveyjs/survey-creator into issu…
Oct 17, 2024
5e46172
work for https://github.com/surveyjs/private-tasks/issues/382 update …
Oct 17, 2024
408b0d6
work for https://github.com/surveyjs/private-tasks/issues/382 update …
Oct 17, 2024
ac51197
Merge branch 'issue/Creator-Settings' of github.com:surveyjs/survey-c…
Oct 17, 2024
dac3290
work for https://github.com/surveyjs/private-tasks/issues/382
Oct 17, 2024
13ca96c
work for https://github.com/surveyjs/private-tasks/issues/382 update …
Oct 17, 2024
302e6a4
work for #5967 Creator settings: refactoring font styles
Oct 17, 2024
bd34881
work for #5967 Creator settings: refactoring font styles
Oct 17, 2024
aa81e0f
work for #5967 Creator settings: refactoring font styles
Oct 17, 2024
00252ce
Merge branch 'master' of github.com:surveyjs/survey-creator into issu…
Oct 17, 2024
d94b547
work for #5967 Creator settings: refactoring font styles
Oct 18, 2024
f5a4acb
work for #5967 Creator settings: refactoring font styles (rollback st…
Oct 18, 2024
b747823
work for #5967 Creator settings: refactoring font styles
Oct 18, 2024
67c1616
work for #5967 Creator settings: refactoring font styles
Oct 18, 2024
eef5fc9
work for #5967 Creator settings: refactoring font styles
Oct 18, 2024
d4b35b7
work for #5967 Creator settings: refactoring font styles
Oct 21, 2024
c81c9b9
work for #5967 Creator settings: refactoring font styles
Oct 21, 2024
a482d22
Merge branch 'master' of github.com:surveyjs/survey-creator into issu…
Oct 21, 2024
8033587
work for #5967 Creator settings: refactoring font styles
Oct 21, 2024
599cd62
Merge branch 'master' of github.com:surveyjs/survey-creator into issu…
Oct 22, 2024
d531ce4
work for #5967 Creator settings: refactoring font styles
Oct 22, 2024
20319d6
work for #5967 Creator settings: refactoring font styles
Oct 22, 2024
2c7e8ba
work for #5967 Creator settings: refactoring font styles
Oct 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
(mouseover)="adorner.hoverStopper && adorner.hoverStopper($event, $event.currentTarget)"
data-bind="clickBubble: false">
<svg class="svc-panel__add-new-question-icon" [iconName]="('icon-add_24x24')" [size]="24" sv-ng-svg-icon></svg>
<span class="svc-text svc-text--normal svc-text--bold">
<span class="svc-add-new-item-button__text">
{{ adorner.addNewQuestionText }}
</span>
<ng-template *ngIf="renderPopup"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<div class="svc-page-navigator-item__dot" [attr.title]="model.title"></div>

<div class="svc-page-navigator-item__banner">
<span class="svc-text svc-text--small svc-text--bold">{{model.title}}</span>
<span class="svc-page-navigator-item__text">{{ model.title }}</span>
<span class="svc-page-navigator-item__dot"></span>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/survey-creator-angular/src/panel.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
(click)="addNewQuestion($event)">
<svg class="svc-panel__add-new-question-icon" [iconName]="('icon-add_24x24')" [size]="24"
sv-ng-svg-icon></svg>
<span class="svc-text svc-text--normal svc-text--bold">
<span class="svc-add-new-item-button__text">
{{ adorner.addNewQuestionText }}
</span>
</div>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<ng-template #template>
<div role="button" class="svc-logic-tab__content-action svc-btn"
(click)="onClick($event)" [key2click] [class.svc-logic-tab__content-action--disabled]="model.enabled !== undefined && !model.enabled">
<span class="svc-text svc-text--normal svc-text--bold">
<span class="svc-add-new-item-button__text">
{{model.title}}
</span>
</div>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<ng-template #template>
<div role="button" class="svc-preview__test-again svc-btn" (click)="action.action()" [key2click]>
<span class="svc-text svc-text--normal svc-text--bold">
<span class="svc-preview-test-again__text">
{{action.title}}
</span>
</div>
Expand Down
6 changes: 2 additions & 4 deletions packages/survey-creator-core/src/components/button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,9 @@
var(--ctr-button-shadow-color, rgba(0, 0, 0, 0.15));

span {
@include ctrDefaultBoldFont;

text-align: center;
font-family: var(--ctr-default-bold-font-family, $font-family);
font-size: var(--ctr-default-bold-font-size, $font-size);
line-height: var(--ctr-default-bold-line-height, calc(1.5 * var(--default-font-size)));
font-weight: var(--ctr-default-bold-font-weight, 600);
position: relative;
display: flex;
align-items: center;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,13 @@
container-type: inline-size;
}
.svc-carry-forward-panel {
@include ctrDefaultFont;
box-sizing: border-box;
width: 100%;
padding: calcSize(4) calcSize(8);
border-radius: calcSize(1);
background-color: $background-dim-light;
text-align: center;
font-weight: 400;
font-size: calcSize(2);
line-height: calcSize(3);
color: $foreground-dim-light;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/survey-creator-core/src/components/creator.scss
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,8 @@ survey-creator,
}

.svc-creator__non-commercial-text {
@include ctrDefaultBoldFont;
color: var(--ctr-page-banner-text-color, $primary-foreground);
@include defaultBold;
vertical-align: middle;
padding: calcSize(1.5) calcSize(16);
display: block;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
}

.svc-logo-image-placeholder {
font-size: calcSize(4);
@include ctrLargeFont;
color: $foreground-light;
opacity: 0.25;
white-space: nowrap;
Expand Down
6 changes: 4 additions & 2 deletions packages/survey-creator-core/src/components/link-value.scss
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
@import "../variables.scss";

.svc-link__button {
@include ctrDefaultBoldFont;
}

.svc-question-link__set-button {
font-weight: 600;
cursor: pointer;
}
.svc-link-value-button {
margin-left: calcSize(-2);
}
.svc-question-link__clear-button {
color: $red;
font-weight: 600;
cursor: pointer;
}
.svc-question-link__clear-button:focus,
Expand Down
4 changes: 2 additions & 2 deletions packages/survey-creator-core/src/components/link-value.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ export class QuestionLinkValueModel extends Question {
public linkClickCallback: () => void;
public resetClickCallback: () => void;
public isClickableCallback: () => boolean;
@property({ defaultValue: "svc-link-value-button svc-question-link__set-button" }) public linkSetButtonCssClasses: string;
@property({ defaultValue: "svc-question-link__clear-button" }) public linkClearButtonCssClasses: string;
@property({ defaultValue: "svc-link__button svc-link-value-button svc-question-link__set-button" }) public linkSetButtonCssClasses: string;
@property({ defaultValue: "svc-link__button svc-question-link__clear-button" }) public linkClearButtonCssClasses: string;

@property({ defaultValue: false }) isSelected: boolean;
@property() linkValueText: string;
Expand Down
4 changes: 2 additions & 2 deletions packages/survey-creator-core/src/components/notifier.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
}

.svc-notifier {
@include ctrSmallBoldFont;

position: absolute;
bottom: calcSize(1);
left: calcSize(1);
Expand All @@ -20,8 +22,6 @@
z-index: 1600; //todo: should overlap popup

visibility: hidden;

@include smallBold;
}

.svc-notifier.svc-notifier--error {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ svc-page-navigator-item,
background: var(--ctr-page-navigator-item-dot-color-default, $border);
}

.svc-page-navigator-item__text {
@include ctrSmallBoldFont;
color: var(--ctr-page-navigator-item-text-color-hovered, #{$foreground});
}

.svc-page-navigator-item--selected {
.svc-page-navigator-item__dot {
width: calcSize(1);
Expand Down Expand Up @@ -90,10 +95,6 @@ svc-page-navigator-item,
top: calcSize(1.75);
right: calcSize(1.75);
}

.svc-text {
color: var(--ctr-page-navigator-item-text-color-hovered);
}
}

.svc-creator__toolbox--right,
Expand Down
9 changes: 7 additions & 2 deletions packages/survey-creator-core/src/components/page.scss
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ svc-page {
}

.svc-element__add-new-question {
.svc-text {
.svc-add-new-item-button__text {
margin-left: calcSize(6);
}
}
Expand All @@ -247,6 +247,11 @@ svc-page {
-webkit-tap-highlight-color: transparent;
}

.svc-add-new-item-button__text {
@include ctrDefaultBoldFont;
color: $foreground;
}

.svc-element__question-type-selector {
appearance: none;
display: flex;
Expand Down Expand Up @@ -317,9 +322,9 @@ svc-page {
}

.sv-list__item.sv-list__item--selected.sv-list__item--group>.sv-list__item-body {
@include ctrDefaultBoldFont;
background-color: $primary;
color: $primary-foreground;
font-weight: 600;
}

.sv-list__item.sv-list__item--selected.sv-list__item--group>.sv-list__item-body use {
Expand Down
2 changes: 1 addition & 1 deletion packages/survey-creator-core/src/components/page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ export class PageAdorner extends SurveyElementAdornerBase<PageModel> {
this._footerActionsBar.containerCss = "svc-page__footer";
this._footerActionsBar.cssClasses = {
item: "svc-btn",
itemTitle: "svc-text svc-text--normal svc-text--bold"
itemTitle: "svc-add-new-item-button__text"
};
let footerActions: Array<IAction> = [{
css: "svc-add-new-question-action",
Expand Down
6 changes: 5 additions & 1 deletion packages/survey-creator-core/src/components/popup.scss
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
}

.sv-popup__body-header {
@include ctrMediumBoldFont;
color: var(--ctr-popup-title-color, $foreground);
}

Expand All @@ -76,6 +77,7 @@
border-bottom: 1px solid var(--ctr-list-search-border-color, $border-inside);

.sv-list__input {
@include ctrDefaultFont;
color: var(--ctr-list-search-text-color-placeholder, $foreground-dim-light);
background-color: transparent;

Expand All @@ -90,6 +92,7 @@
}

.sv-list__item-body {
@include ctrDefaultFont;
color: var(--ctr-list-item-text-color, $foreground-dim);
transition: background-color $creator-transition-duration, color $creator-transition-duration;
}
Expand All @@ -110,6 +113,7 @@
.sv-list__item--selected,
.sv-list__item.sv-list__item--selected:hover {
& > .sv-list__item-body {
@include ctrDefaultBoldFont;
color: var(--ctr-list-item-text-color-selected, $primary-foreground);
background: var(--ctr-list-item-background-color-selected, $primary);
}
Expand Down Expand Up @@ -185,7 +189,6 @@
& > .sv-list__item-body {
background: var(--ctr-list-item-background-color-selected, $primary-light);
color: var(--ctr-list-item-text-color-selected, $foreground);
font-weight: 400;
}

.sv-list__item-icon use {
Expand All @@ -206,6 +209,7 @@
}

.sv-popup__content {
@include ctrDefaultFont;
color: var(--ctr-popup-message-color, #404040);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -60,23 +60,15 @@
width: 100%;
}
.svc-property-grid-placeholder__title {
@include ctrDefaultBoldFont;
color: var(--ctr-property-grid-placeholder-text-title-color, rgba(0, 0, 0, 0.91));
text-align: center;
font-family: var(--ctr-font-family, "Open Sans");
font-size: var(--ctr-font-default-size, 16px);
font-style: normal;
font-weight: 600;
line-height: var(--ctr-font-default-line-height, 24px) /* 150% */;
display: inline-block;
}
.svc-property-grid-placeholder__description {
@include ctrSmallFont;
color: var(--ctr-property-grid-placeholder-text-description-color, rgba(0, 0, 0, 0.45));
text-align: center;
font-family: var(--ctr-font-family, "Open Sans");
font-size: var(--ctr-font-small-size, 12px);
font-style: normal;
font-weight: 400;
line-height: var(--ctr-font-small-line-height, 16px) /* 133.333% */;
display: inline-block;
}
.svc-property-grid-placeholder__content {
Expand Down
18 changes: 7 additions & 11 deletions packages/survey-creator-core/src/components/question.scss
Original file line number Diff line number Diff line change
Expand Up @@ -263,14 +263,10 @@ svc-question {
}

.svc-panel__placeholder {
@include ctrDefaultFont;
color: $foreground-light;
text-wrap: wrap;
text-align: center;

font-size: calcSize(2);
font-style: normal;
font-weight: 400;
line-height: calcSize(3);
}

.svc-question__content-actions {
Expand Down Expand Up @@ -521,7 +517,7 @@ svc-question {
}

.svc-dragged-element-shortcut__text {
@include smallBold;
@include ctrSmallBoldFont;
line-height: calcSize(2);
}

Expand Down Expand Up @@ -999,13 +995,13 @@ svc-question,
outline: none;
}

.svc-text {
.svc-add-new-item-button__text {
display: flex;
align-items: center;
flex-grow: 1;
justify-content: center;
margin: calcSize(1) calcSize(3);
line-height: calcSize(2);
line-height: var(--sjs-line-height-x2, #{calcSize(2)});
color: var(--ctr-survey-action-button-text-color-positive, $primary);
text-wrap: nowrap;
}
Expand Down Expand Up @@ -1075,13 +1071,13 @@ svc-question,
outline: none;
}

.svc-text {
.svc-add-new-item-button__text {
display: flex;
align-items: center;
flex-grow: 1;
justify-content: center;
margin: calcSize(1) calcSize(3);
line-height: calcSize(2);
line-height: var(--sjs-line-height-x2, #{calcSize(2)});
color: var(--ctr-survey-action-button-text-color-positive, $primary);
text-wrap: nowrap;
}
Expand Down Expand Up @@ -1168,7 +1164,7 @@ svc-question,
.svc-element__add-new-question {
padding: calcSize(0.5) calcSize(0.5);

.svc-text {
.svc-add-new-item-button__text {
display: none;
}
}
Expand Down
Loading