Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance] Adorners are created for all questions when switching from Preview to Designer #6029

Closed
andrewtelnov opened this issue Nov 3, 2024 · 0 comments · Fixed by surveyjs/survey-library#9010
Closed

[Performance] Adorners are created for all questions when switching from Preview to Designer #6029

andrewtelnov opened this issue Nov 3, 2024 · 0 comments · Fixed by surveyjs/survey-library#9010
Assignees
@tsv2013
Labels
bug performance issue
Milestone
v1.12.11

Comments

@andrewtelnov
Copy link
Member

andrewtelnov commented Nov 3, 2024 •
edited
Loading

Create a survey with 5 pages and add many questions, let's say 20 to the last page. Then select the first question, go to the Preview tab and go back to Designer tab. You will see that adorners for all questions will be created.
It kills performance for extremely large surveys.
tsv2013 pushed a commit to surveyjs/survey-library that referenced this issue Nov 5, 2024
Fixed surveyjs/survey-creator#6029 - Performance: On switching from P…
dc185fd 
…review to Designer adorners are created for all questions
@tsv2013 tsv2013 linked a pull request Nov 5, 2024 that will close this issue
Fixed https://github.com/surveyjs/survey-creator/issues/6029 - Performance: On switching from Preview to Designer adorners are created for all questions surveyjs/survey-library#9010
Merged
tsv2013 added a commit to surveyjs/survey-library that referenced this issue Nov 5, 2024
@tsv2013
Fixed surveyjs/survey-creator#6029 - Performance: On switching from P…
b6d33c7 
…review to Designer adorners are created for all questions (#9010)

Co-authored-by: tsv2013 <[email protected]>
@tsv2013 tsv2013 reopened this Nov 5, 2024
tsv2013 pushed a commit to surveyjs/survey-library that referenced this issue Nov 7, 2024
Work for surveyjs/survey-creator#6029 - reset links to DOM element an…
b354115 
…d lelease resouces on dispose
tsv2013 pushed a commit that referenced this issue Nov 7, 2024
Work for #6029 - Performance: On switching from Preview to Designer a…
0831c07 
…dorners are created for all questions - fixed memory leaks (React)
@tsv2013 tsv2013 mentioned this issue Nov 7, 2024
Merged
tsv2013 added a commit to surveyjs/survey-library that referenced this issue Nov 8, 2024
@tsv2013
Fixed some performance issus and memory leaks (#9015)
ba076cd 
* Work for surveyjs/survey-creator#6029 - reset links to DOM element and lelease resouces on dispose

* Fixed wrong change

* Dispose computed updater with the owner object

* Fixed errors in creator

* Restored file

* Restored fix

* Returned changes back

---------

Co-authored-by: tsv2013 <[email protected]>
tsv2013 added a commit that referenced this issue Nov 15, 2024
@tsv2013
Fixed memory leaks in Creator (#6047)
ce73974 
* Work for #6029 - Performance: On switching from Preview to Designer adorners are created for all questions - fixed memory leaks (React)

* Fixed lint

* Fixed unit tests

* Fixed unit test

* Fixed question adorner memory leak adorner <-> action circular reference

* Fixed u-test

* Added memory leak test for tabs switching

* Fixed unit and f-tests

* Update performance.ts

* Fixed large json question duplicated names

* Fixed errors in knockout

* Fixed f-tests and updated etalons

* Removed test.only

* Fixed VueJS build

* Updated etalons

* Got rid of ref to toolbox root DOM element

* Added mask

* Fixed f-test

---------

Co-authored-by: tsv2013 <[email protected]>
@tsv2013 tsv2013 closed this as completed Nov 18, 2024
@OlgaLarina OlgaLarina added this to the v1.12.11 milestone Nov 19, 2024
@RomanTsukanov RomanTsukanov changed the title Performance: On switching from Preview to Designer adorners are created for all questions [Performance] Adorners are created for all questions when switching from Preview to Designer Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsv2013 tsv2013

Labels
bug performance issue
Projects
None yet
Milestone
v1.12.11
3 participants
@tsv2013 @andrewtelnov @OlgaLarina