Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pages drag/drop on design surface #5873

Closed
tsv2013 opened this issue Sep 10, 2024 · 5 comments · Fixed by #5928
Closed

Implement pages drag/drop on design surface #5873

tsv2013 opened this issue Sep 10, 2024 · 5 comments · Fixed by #5928
Assignees
@tsv2013
Labels
enhancement v2.0
Milestone
v1.12.6

Comments

@tsv2013
Copy link
Member

tsv2013 commented Sep 10, 2024 •
edited
Loading

Add an option to collapse all pages on drag start and restore their state back on drag end
@tsv2013 tsv2013 self-assigned this Sep 10, 2024
@tsv2013
Copy link
Member Author

tsv2013 commented Oct 1, 2024

https://www.figma.com/design/SSMZUWJve1zuMSeA5E5YpA/CTR--%3E-Creator-Preview?node-id=2586-4780

tsv2013 pushed a commit that referenced this issue Oct 1, 2024
Resolved #5873 - Implement pages drag/drop on design surface
5593764
@tsv2013 tsv2013 mentioned this issue Oct 1, 2024
Merged
@andrewtelnov
Copy link
Member

andrewtelnov commented Oct 2, 2024 •
edited
Loading

  1. Page title edtor is activated after dragging
  2. When pages are collapsed, the state of pages should be restored after dragging. It is even more imporant on canceling dragging

@mikeamelin
Copy link

mikeamelin commented Oct 2, 2024 •
edited by tsv2013
Loading

  • maybe same issue as for question, but looks a bit more unpleasure. Showing/hiding drag indicator makes unnecessary blinking. Also it is still weird that no ability to drop between items
Screen.Recording.2024-10-02.at.15.26.34.mov
  • agree with two points that Andrew mentioned
  • sometimes drag indicator remains on the surface
Screenshot 2024-10-02 at 15 27 53
  • after a couple of actions a one page stops collapsing at all
Screen.Recording.2024-10-02.at.15.51.06.mov
  • we forget to change appearance of dragging page on the surface as we do for question (change opacity)
Screenshot 2024-10-02 at 15 47 30

tsv2013 pushed a commit that referenced this issue Oct 2, 2024
Work for #5873 - Implement pages drag/drop on design surface - implem…
c691cc9 
…ented dragging in Angular, Vue and KO
tsv2013 pushed a commit that referenced this issue Oct 7, 2024
Work for #5873 - Implement pages drag/drop on design surface - fixed …
3c6b320 
…remarks
@mikeamelin
Copy link

mikeamelin commented Oct 8, 2024 •
edited by tsv2013
Loading

  • keep current page collapsed if it was collapsed before dragging
Screen.Recording.2024-10-08.at.12.00.10.mov
  • drag grip shifts up no hover
Screen.Recording.2024-10-08.at.11.58.15.mov

@JaneSjs
Copy link
Contributor

JaneSjs commented Oct 9, 2024

A page is blinking and is expanded automatically. Follow these steps:
PagesDragDropCreatorDemo (1).zip

  1. Run index2.html.
  2. Collapse All pages.
  3. Drop 4th page at the 1st position.
  4. Drop the 4th page under the 1st page.
  5. Click outsite or wait for a second.
  6. You'll see the 3rd question starts blinking.
2024-10-09_20-03-56.mp4

@OlgaLarina OlgaLarina added this to the v1.12.6 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsv2013 tsv2013

Labels
enhancement v2.0
Projects
None yet
Milestone
v1.12.6
Development

Successfully merging a pull request may close this issue.

Resolved #5873 - Implement pages drag/drop on design surface surveyjs/survey-creator
5 participants
@tsv2013 @andrewtelnov @OlgaLarina @mikeamelin @JaneSjs