Skip to content

Commit

Permalink
PR: Incorrect positioning of drag-n-drop indicators after designer su…
Browse files Browse the repository at this point in the history
…rface scaling. (#6183)

* work for the #6158

* work for the #6158

* work for the #6158
  • Loading branch information
dmitry-kurmanov authored Dec 5, 2024
1 parent 5e446dc commit f7bc3f2
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 15 deletions.
8 changes: 5 additions & 3 deletions packages/survey-creator-core/src/components/page.scss
Original file line number Diff line number Diff line change
Expand Up @@ -387,14 +387,16 @@ svc-page {
}
}

.svc-page--drag-over-empty:after {
.svc-page--drag-over-empty .svc-page__footer:after {
content: " ";
position: absolute;
background: $secondary;
left: calcSize(3);
bottom: calcSize(11.5);
width: calc(100% - 48px);
height: 2px;
width: 100%;
height: calcSize(0.25);
left: 0;
top: calc(calcSize(-1) - (calcSize(0.25) / 2));
}

.svc-page--drag-over-empty-no-add-button:after {
Expand Down
24 changes: 12 additions & 12 deletions packages/survey-creator-core/src/components/question.scss
Original file line number Diff line number Diff line change
Expand Up @@ -703,59 +703,59 @@ svc-question {
}

.svc-question__drop-indicator--left {
left: -9px;
left: calc(calcSize(-1) - (calcSize(0.25) / 2));
}

.svc-question__drop-indicator--right {
right: -9px;
right: calc(calcSize(-1) - (calcSize(0.25) / 2));
}

.svc-question__drop-indicator--top {
top: -9px;
top: calc(calcSize(-1) - (calcSize(0.25) / 2));
}

.svc-question__drop-indicator--bottom {
bottom: -9px;
bottom: calc(calcSize(-1) - (calcSize(0.25) / 2));
}

.svc-question__content--drag-over-left {
> .svc-question__drop-indicator--left {
opacity: 1;
width: 2px;
width: calcSize(0.25);
}
}

.svc-question__content--drag-over-right {
> .svc-question__drop-indicator--right {
opacity: 1;
width: 2px;
width: calcSize(0.25);
}
}

.svc-question__content--drag-over-top {
> .svc-question__drop-indicator--top {
opacity: 1;
height: 2px;
height: calcSize(0.25);
}
}

.svc-question__content--drag-over-bottom {
> .svc-question__drop-indicator--bottom {
opacity: 1;
height: 2px;
height: calcSize(0.25);
}
}

.sd-panel {
.svc-question__content--drag-over-left {
.svc-question__drop-indicator--left {
left: -6px;
left: calc(calcSize(-1) + calcSize(0.25));
}
}

.svc-question__content--drag-over-right {
.svc-question__drop-indicator--right {
right: -6px;
right: calc(calcSize(-1) + calcSize(0.25));
}
}
}
Expand All @@ -778,13 +778,13 @@ svc-question {

.svc-question__content--drag-over-top {
.svc-question__drop-indicator--top {
top: -6px;
top: calc(calcSize(-1) + calcSize(0.25));
}
}

.svc-question__content--drag-over-bottom {
.svc-question__drop-indicator--bottom {
bottom: -6px;
bottom: calc(calcSize(-1) + calcSize(0.25));
}
}
}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified visualRegressionTests/tests/designer/etalons/drag-drop-scroll.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit f7bc3f2

Please sign in to comment.