#6296 Clear button corners (#6297)

* #6296 Clear button corners Fixes #6296 * #6296 Clear button corners Fixes #6296
surveyjs · Dec 23, 2024 · b81c55f · b81c55f
1 parent ad97ce0
commit b81c55f
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 2 deletions.
diff --git a/packages/survey-creator-core/src/components/link-value.scss b/packages/survey-creator-core/src/components/link-value.scss
@@ -2,6 +2,7 @@
 
 .svc-link__button {
   @include ctrDefaultBoldFont;
+  border-radius: var(--ctr-actionbar-button-corner-radius, calcSize(12.5));
 }
 
 .svc-question-link__set-button {
@@ -10,7 +11,6 @@
 .svc-link-value-button {
   --thm-margin-inline-start: calc(-1 * var(--ctr-actionbar-button-padding-left-medium-text));
   margin-inline-start: var(--thm-margin-inline-start, calcSize(-2));
-  border-radius: var(--ctr-actionbar-button-corner-radius, calcSize(12.5));
 }
 .svc-question-link__clear-button {
   color: $red;

diff --git a/visualRegressionTests-V2/tests/designer/etalons/action-clear-button-hovered.png b/visualRegressionTests-V2/tests/designer/etalons/action-clear-button-hovered.png
diff --git a/...lRegressionTests-V2/tests/designer/etalons/default-value-clear-button-focus.png b/...lRegressionTests-V2/tests/designer/etalons/default-value-clear-button-focus.png
diff --git a/visualRegressionTests/tests/designer/etalons/action-clear-button-hovered.png b/visualRegressionTests/tests/designer/etalons/action-clear-button-hovered.png
diff --git a/visualRegressionTests/tests/designer/pg-data-action-button.ts b/visualRegressionTests/tests/designer/pg-data-action-button.ts
@@ -1,4 +1,4 @@
-import { Selector } from "testcafe";
+import { ClientFunction, Selector } from "testcafe";
 import { url, setJSON, wrapVisualTest, takeElementScreenshot } from "../../helper";
 
 const title = "ValueLink Actions in Data section Screenshot";
@@ -39,5 +39,12 @@ test("Check states", async (t) => {
 
     await t.hover(buttonElement);
     await takeElementScreenshot("action-button-hovered.png", buttonElement, t, comparer);
+
+    await ClientFunction(() => {
+      window["creator"].survey.getAllQuestions()[0].defaultValue = "val";
+    })();
+    const clearButtonElement = Selector(".svc-link__button.svc-question-link__clear-button.svc-action-button");
+    await t.hover(clearButtonElement);
+    await takeElementScreenshot("action-clear-button-hovered.png", clearButtonElement, t, comparer);
   });
 });