Skip to content

Commit

Permalink
Exclude survey-core/themes from survey-creator-core bundle (#5812)
Browse files Browse the repository at this point in the history
* work for #5773 Exclude survey-core/themes from survey-creator-core bundle

* Fixed unit tests

* Fixed f and vr -tests - loaded themes

* Fixed test pages - load themes

* Fixed error if themes hasn't been loaded

* Added empty default theme json

---------

Co-authored-by: OlgaLarina <[email protected]>
Co-authored-by: tsv2013 <[email protected]>
  • Loading branch information
3 people authored Sep 5, 2024
1 parent 33d010a commit 802712e
Show file tree
Hide file tree
Showing 35 changed files with 47 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { updateCustomQuestionJSONs } from "./theme-custom-questions";

export * from "./header-model";

Object.keys(LibraryThemes).forEach(libraryThemeName => {
Object.keys(LibraryThemes || {}).forEach(libraryThemeName => {
const libraryTheme: ITheme = LibraryThemes[libraryThemeName];
const creatorThemeVariables = {};
const creatorTheme = {};
Expand Down Expand Up @@ -89,7 +89,7 @@ export function getThemeChanges(fullTheme: ITheme, baseTheme?: ITheme) {
}

export class ThemeModel extends Base implements ITheme {
public static DefaultTheme = Themes["default-light"];
public static DefaultTheme = Themes["default-light"] || {};
public undoRedoManager: UndoRedoManager;
private themeCssVariablesChanges: { [index: string]: string } = {};
private colorCalculator = new ColorCalculator();
Expand Down
12 changes: 6 additions & 6 deletions packages/survey-creator-core/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -179,18 +179,18 @@ module.exports = function (options) {
umdNamedDefine: true
},
externals: {
knockout: {
root: "ko",
commonjs2: "knockout",
commonjs: "knockout",
amd: "knockout",
},
"survey-core": {
root: "Survey",
commonjs2: "survey-core",
commonjs: "survey-core",
amd: "survey-core",
},
"survey-core/themes": {
root: "SurveyTheme",
commonjs2: "survey-core/themes",
commonjs: "survey-core/themes",
amd: "survey-core/themes",
},
},
plugins: [
new DashedNamePlugin(),
Expand Down
1 change: 1 addition & 0 deletions packages/survey-creator-js/testCafe/by-page.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-js.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-js-ui/survey-js-ui.js"></script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-js.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-js-ui/survey-js-ui.js"></script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-js.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-js-ui/survey-js-ui.js"></script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-js.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-js-ui/survey-js-ui.js"></script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-js.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-js-ui/survey-js-ui.js"></script>
Expand Down
1 change: 1 addition & 0 deletions packages/survey-creator-js/testCafe/testcafe-widget.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-js.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-js-ui/survey-js-ui.js"></script>
Expand Down
1 change: 1 addition & 0 deletions packages/survey-creator-js/testCafe/testcafe.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-js.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-js-ui/survey-js-ui.js"></script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-js.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-js-ui/survey-js-ui.js"></script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-js.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-js-ui/survey-js-ui.js"></script>
Expand Down
1 change: 1 addition & 0 deletions packages/survey-creator-knockout/example/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
<script src="https://cdnjs.cloudflare.com/ajax/libs/select2/4.0.3/js/select2.min.js"></script> -->

<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-knockout-ui/survey-knockout-ui.js"></script>
<link rel="stylesheet" type="text/css" href="../node_modules/survey-core/defaultV2.css" />
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
Expand Down
1 change: 1 addition & 0 deletions packages/survey-creator-knockout/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

<script src="./node_modules/survey-core/survey.core.js"></script>
<script src="./node_modules/survey-core/survey.i18n.min.js"></script>
<script src="./node_modules/survey-core/themes/index.js"></script>
<script src="./node_modules/survey-knockout-ui/survey-knockout-ui.js"></script>
<script src="./node_modules/survey-creator-core/survey-creator-core.js"></script>

Expand Down
2 changes: 1 addition & 1 deletion packages/survey-creator-knockout/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module.exports = {
moduleNameMapper: {
"\\.(css|scss)$": "<rootDir>/tests/empty-module.js",
"\\.(jpg|png)$": "<rootDir>/tests/empty-module.js",
"survey-core": "<rootDir>/node_modules/survey-core",
"^survey-core(.*)$": "<rootDir>/node_modules/survey-core$1",
"survey-creator-core": "<rootDir>/node_modules/survey-creator-core",
"survey-knockout-ui": "<rootDir>/node_modules/survey-knockout-ui",
"tslib": "<rootDir>/node_modules/tslib",
Expand Down
1 change: 1 addition & 0 deletions packages/survey-creator-knockout/testCafe/by-page.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-knockout.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-knockout.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>

Expand All @@ -25,7 +26,7 @@
</div>
<script>
window.surveyJSFramework = "ko";
const creator = new SurveyCreator.SurveyCreator({maxVisibleChoices: 5});
const creator = new SurveyCreator.SurveyCreator({ maxVisibleChoices: 5 });
window.creator = creator;
ko.applyBindings({ creator: creator });
</script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-knockout.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-knockout.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-knockout.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-knockout-ui/survey-knockout-ui.js"></script>
<script src="../build/survey-creator-knockout.js"></script>
<script src="./sc.js"></script>
Expand Down
1 change: 1 addition & 0 deletions packages/survey-creator-knockout/testCafe/testcafe.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-knockout.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-knockout.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-knockout.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>

Expand All @@ -27,7 +28,7 @@
</div>
<script>
window.surveyJSFramework = "ko";
const creator = new SurveyCreator.SurveyCreator({themeForPreview: "modern"});
const creator = new SurveyCreator.SurveyCreator({ themeForPreview: "modern" });
window.creator = creator;
ko.applyBindings({ creator: creator });
</script>
Expand Down
7 changes: 4 additions & 3 deletions packages/survey-creator-react/example/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,12 @@
<link href="https://cdnjs.cloudflare.com/ajax/libs/select2/4.0.3/css/select2.min.css" rel="stylesheet" />
<script src="https://cdnjs.cloudflare.com/ajax/libs/select2/4.0.3/js/select2.min.js"></script> -->

<script src="http://127.0.0.1:7766/build/survey-core/survey.core.js"></script>
<script src="http://127.0.0.1:7766/build/survey-react-ui/survey-react-ui.js"></script>
<script src="../../node_modules/survey-core/survey.core.js"></script>
<script src="../../node_modules/survey-core/themes/index.js"></script>
<script src="../../node_modules/survey-react-ui/survey-react-ui.js"></script>
<script src="../../survey-creator-core/build/survey-creator-core.js"></script>
<script src="../build/survey-creator-react.js"></script>
<link rel="stylesheet" type="text/css" href="http://127.0.0.1:7766/build/survey-core/defaultV2.css" />
<link rel="stylesheet" type="text/css" href="../../node_modules/survey-core/defaultV2.css" />
<link rel="stylesheet" type="text/css" href="../../survey-creator-core/build/survey-creator-core.css" />
</head>

Expand Down
3 changes: 2 additions & 1 deletion packages/survey-creator-react/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@
<script src="https://cdnjs.cloudflare.com/ajax/libs/babel-core/5.8.23/browser.js"></script>

<script src="./node_modules/survey-core/survey.core.js"></script>
<script src="./node_modules/survey-core/survey.i18n.min.js"></script>
<script src="./node_modules/survey-core/themes/index.js"></script>
<script src="./node_modules/survey-react-ui/survey-react-ui.js"></script>
<script src="./node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="./node_modules/survey-core/survey.i18n.min.js"></script>

<!--<script src="./build/survey-creator-react.js"></script>-->
<link rel="stylesheet" type="text/css" href="./node_modules/survey-core/defaultV2.css" />
Expand Down
2 changes: 1 addition & 1 deletion packages/survey-creator-react/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module.exports = {
"\\.(css|scss)$": "<rootDir>/tests/empty-module.js",
"\\.(jpg|png)$": "<rootDir>/tests/empty-module.js",
"^react(.*)$": "<rootDir>/node_modules/react$1",
"survey-core": "<rootDir>/node_modules/survey-core",
"^survey-core(.*)$": "<rootDir>/node_modules/survey-core$1",
"survey-creator-core": "<rootDir>/node_modules/survey-creator-core",
"survey-react-ui": "<rootDir>/node_modules/survey-react-ui",
"tslib": "<rootDir>/node_modules/tslib",
Expand Down
1 change: 1 addition & 0 deletions packages/survey-creator-react/testCafe/by-page.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-react.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-react-ui/survey-react-ui.js"></script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-react.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-react-ui/survey-react-ui.js"></script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-react.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-react-ui/survey-react-ui.js"></script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-react.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-react-ui/survey-react-ui.js"></script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-react.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-react-ui/survey-react-ui.js"></script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-react.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-react-ui/survey-react-ui.js"></script>
Expand Down
1 change: 1 addition & 0 deletions packages/survey-creator-react/testCafe/testcafe.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-react.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-react-ui/survey-react-ui.js"></script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<!-- <link rel="stylesheet" type="text/css" href="../build/survey-creator-react.min.css" /> -->
<script src="../node_modules/survey-core/survey.core.js"></script>
<script src="../node_modules/survey-core/survey.i18n.js"></script>
<script src="../node_modules/survey-core/themes/index.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.js"></script>
<script src="../node_modules/survey-creator-core/survey-creator-core.i18n.js"></script>
<script src="../node_modules/survey-react-ui/survey-react-ui.js"></script>
Expand Down
Loading

0 comments on commit 802712e

Please sign in to comment.