Fixed #5282 - If question width is small for text type then changing …

…input type breaks adaptivity
surveyjs · Mar 7, 2024 · 70b05fa · 70b05fa
1 parent 8713e7c
commit 70b05fa
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/packages/survey-creator-react/src/ModelElement.tsx b/packages/survey-creator-react/src/ModelElement.tsx
@@ -8,19 +8,19 @@ export class CreatorModelElement<P, S> extends SurveyElementBase<P, S> {
   shouldComponentUpdate(nextProps: any, nextState: any): boolean {
     const result = super.shouldComponentUpdate(nextProps, nextState);
     if (result) {
-      if (this.needUpdateModel(this.props)) {
+      if (this.needUpdateModel(nextProps)) {
         this.createModel(nextProps);
       }
     }
     return result;
   }
   protected createModel(props: any): void { }
-  protected needUpdateModel(prevProps: any): boolean {
+  protected needUpdateModel(nextProps: any): boolean {
     const names = this.getUpdatedModelProps();
     if (!Array.isArray(names)) return true;
     for (var i = 0; i < names.length; i++) {
       const key = names[i];
-      if (this.props[key] !== prevProps[key]) return true;
+      if (this.props[key] !== nextProps[key]) return true;
     }
     return false;
   }

diff --git a/visualRegressionTests/tests/designer/etalons/actions-on-converted-question.png b/visualRegressionTests/tests/designer/etalons/actions-on-converted-question.png
diff --git a/...alRegressionTests/tests/designer/etalons/actions-on-converted-question_mask.png b/...alRegressionTests/tests/designer/etalons/actions-on-converted-question_mask.png
diff --git a/visualRegressionTests/tests/designer/surface.ts b/visualRegressionTests/tests/designer/surface.ts
@@ -1999,6 +1999,7 @@ test("Check adorner actions responsivity after convert", async (t) => {
       .click(Selector("div[data-sv-drop-target-survey-element='question3'] .sv-list__item-body[title='Yes/No (Boolean)']"))
       .hover(Selector(".svc-question__adorner").nth(1), { offsetX: 10, offsetY: 10 }).click(Selector(".svc-question__adorner").nth(1), { offsetX: 10, offsetY: 10 })
       .hover(Selector(".svc-question__adorner").nth(2), { offsetX: 10, offsetY: 10 }).click(Selector(".svc-question__adorner").nth(2), { offsetX: 10, offsetY: 10 });
+    await ClientFunction(() => { document.body.focus(); })();
     await t.wait(100);
     await takeElementScreenshot("actions-on-converted-question.png", root.nth(0), t, comparer);
   });