Fixed surveyjs/survey-library#8797 - Advanced Header - The header hei…

…ght is decreased on a mobile and a header image is undistinguishable (#5905) * Fixed surveyjs/survey-library#8797 - Advanced Header - The header height is decreased on a mobile and a header image is undistinguishable * Fixed tests --------- Co-authored-by: tsv2013 <[email protected]>
surveyjs · Sep 19, 2024 · 5bbe9cf · 5bbe9cf
1 parent 2ed2297
commit 5bbe9cf
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 0 deletions.
diff --git a/packages/survey-creator-core/src/components/tabs/header-model.ts b/packages/survey-creator-core/src/components/tabs/header-model.ts
@@ -5,6 +5,7 @@ import { assign } from "../../utils/utils";
 
 export class HeaderModel extends Base implements IHeader {
   height: number;
+  mobileHeight: number;
   inheritWidthFrom: "survey" | "container";
   textAreaWidth: number;
   overlapEnabled: boolean;
@@ -176,6 +177,18 @@ Serializer.addClass(
         }
       }
     },
+    {
+      type: "spinedit",
+      name: "mobileHeight",
+      visibleIf: (obj) => obj.headerView === "advanced",
+      default: 0,
+      onPropertyEditorUpdate: function (obj: any, editor: any) {
+        if (!!editor) {
+          editor.unit = "px";
+          editor.min = 0;
+        }
+      }
+    },
     {
       type: "buttongroup",
       name: "inheritWidthFrom",

diff --git a/packages/survey-creator-core/src/components/tabs/theme-model-definition.ts b/packages/survey-creator-core/src/components/tabs/theme-model-definition.ts
@@ -66,6 +66,7 @@ const themeModelProperties: ISurveyPropertiesDefinition = {
       { name: "surveyTitle" },
       { name: "surveyDescription" },
       { name: "height", tab: "layout" },
+      { name: "mobileHeight", tab: "layout" },
       { name: "inheritWidthFrom", tab: "layout" },
       { name: "textAreaWidth", tab: "layout" },
 

diff --git a/packages/survey-creator-core/tests/tabs/theme-model-property-grid.tests.ts b/packages/survey-creator-core/tests/tabs/theme-model-property-grid.tests.ts
@@ -752,6 +752,7 @@ test("headerViewContainer init state", (): any => {
     "descriptionPositionY": "bottom",
     "textAreaWidth": 512,
     "height": 256,
+    "mobileHeight": 0,
     "headerDescription": {
       "family": "Open Sans",
       "size": 16,

diff --git a/...sts/tests/designer/etalons/theme-editor-property-grid-header-group-advanced.png b/...sts/tests/designer/etalons/theme-editor-property-grid-header-group-advanced.png