Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to http/hyper v1.0 #3726

Merged
merged 55 commits into from
Aug 7, 2024

Conversation

RaphaelDarley
Copy link
Contributor

@RaphaelDarley RaphaelDarley commented Mar 20, 2024

What is the motivation?

The rust web ecosystem currently shifted as the hyper and http crates have stabilised on v1.0. SurrealDB should move onto these new standards to allow integration with new crates and allow better maintainability.

What does this change do?

bumps versions of http, hyper, axum and related crates and makes changes to account for the differences in their apis

What is your testing strategy?

This pr does not change any behaviour so relying on existing tests

Is this related to any issues?

Does this change need documentation?

  • No documentation needed

Have you read the Contributing Guidelines?

@RaphaelDarley
Copy link
Contributor Author

now waiting on: hyperium/tonic#1740, then for opentelemetry to be updated with tonic 0.12.

@RaphaelDarley RaphaelDarley marked this pull request as ready for review August 6, 2024 14:40
@RaphaelDarley RaphaelDarley requested review from a team and tobiemh as code owners August 6, 2024 14:40
Cargo.toml Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
lib/Cargo.toml Outdated Show resolved Hide resolved
src/net/import.rs Outdated Show resolved Hide resolved
src/net/health.rs Outdated Show resolved Hide resolved
src/net/signup.rs Outdated Show resolved Hide resolved
src/net/sql.rs Outdated Show resolved Hide resolved
src/telemetry/metrics/ws/mod.rs Show resolved Hide resolved
src/telemetry/mod.rs Outdated Show resolved Hide resolved
tests/ml_integration.rs Outdated Show resolved Hide resolved
@tobiemh tobiemh changed the title upgrade to http/hyper v1.0 Upgrade to http/hyper v1.0 Aug 7, 2024
Copy link
Contributor

@gguillemas gguillemas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changes to dependencies. There are some minor updates to crates that we already trusted and that do not include any additional access to Rust APIs. New access seems reasonable. The new dependencies prost and quinn are both well maintained and widely used within the Rust ecosystem, the later has published security advisories in the past. For crates developed by Sean McArthur (AKA seanmonstar), we have agreed to trust the author on the grounds that we sponsor them and that they are personally known to SurrealDB and to the Rust community and have a history for publicly addressing security issues [1, 2, 3] as well as developing libraries that are well maintained and widely used.

@RaphaelDarley RaphaelDarley added this pull request to the merge queue Aug 7, 2024
Merged via the queue into surrealdb:main with commit 4f3b963 Aug 7, 2024
24 checks passed
@RaphaelDarley RaphaelDarley deleted the upgrade-axum-to-0.7 branch August 7, 2024 11:01
@rushmorem rushmorem added this to the v2.0.0-alpha.10 milestone Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants