Add toleration for StringRecordId (#372) #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kearfy
approved these changes
Nov 11, 2024
kearfy
reviewed
Nov 11, 2024
|
Hey @knackstedt, thank you for this PR! Instead of casting the value to |
|
@kearfy Thanks, I've made that alteration via a force change to keep history clean. Does that look good? |
kearfy
reviewed
Nov 12, 2024
|
Awesome thanks @knackstedt! There was just one more formatting issue but I resolved that for you. I'll try to look at your other issues soon! |
|
Awesome, thanks @kearfy! I didn't make PRs for the other issues -- They seemed like they needed your concensus and understanding of the internals. I did mention them to Ignacio though, FWIW |
|
Yeah, Ignacio let me know as well 👍 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
PR #372.
What does this change do?
Checks if the provided argument is already an instance of a StringRecordId.
What is your testing strategy?
There is not already a test file for StringRecordId. My code change adds 2 lines and it's simple enough to know it's not going to implode.
Is this related to any issues?
#372
Have you read the Contributing Guidelines?