Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable gaps #364

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Reusable gaps #364

merged 2 commits into from
Oct 18, 2024

Conversation

kearfy
Copy link
Member

@kearfy kearfy commented Oct 18, 2024

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

For every run of the tagged-template method, we can re-use a binding for gaps, so that the value will be transferred just once.

What does this change do?

Updated the logic to re-use bindings where possible.

What is your testing strategy?

Added a test.

Is this related to any issues?

  • No

Have you read the Contributing Guidelines?

@kearfy kearfy marked this pull request as ready for review October 18, 2024 10:24
@kearfy kearfy merged commit 065e799 into main Oct 18, 2024
10 checks passed
@kearfy kearfy deleted the micha/reusable-gaps branch October 18, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants