Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parentheses to avoid warnings during compilation in elixir 1.17 #16

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

perzanko
Copy link
Member

@perzanko perzanko commented Jul 1, 2024

It resolves this warning reported during compilation:

warning: using map.field notation (without parentheses) to invoke function Fresha.Waitlists.Protobuf.Rpc.V1.RPCService.Service.__rpc_calls__() is deprecated, you must add parentheses instead: remote.function()
  lib/waitlists_rpc/grpc/server.ex:6: (module)
  (elixir 1.17.1) src/elixir_compiler.erl:77: :elixir_compiler.dispatch/4
  (elixir 1.17.1) src/elixir_compiler.erl:52: :elixir_compiler.compile/4
  (elixir 1.17.1) src/elixir_module.erl:427: :elixir_module.eval_form/7
  (elixir 1.17.1) src/elixir_module.erl:129: :elixir_module.compile/7

Compilation failed due to warnings while using the --warnings-as-errors option

Copy link

@JerzyDziala JerzyDziala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@glizda glizda merged commit 3439ee2 into master Jul 2, 2024
8 checks passed
@glizda glizda deleted the fix-warning-in-elixir-1-17 branch July 2, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants