Absolute Pitch Shift #957
Merged
Absolute Pitch Shift #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing surge-synthesizer#865, we want to be able to shift pitch by either a relative (note space) frequency or an absolute (frequency space) frequency amount. The implementation works as follows: 1. Make the pitch parameter allow absolute for pitch_semi_7b 2. Make sure the absolute property saves and restores 3. In SurgeVoice plumb through a note-setter function which will allow us to find the note equivalent to the absolute shift from a base 4. An implementation of constant pitch shift to note which uses the current tuning table to interpolate in absolute mode and just adds in normal mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #865, we want to be able to shift pitch by either a
relative (note space) frequency or an absolute (frequency space)
frequency amount.
The implementation works as follows:
will allow us to find the note equivalent to the absolute
shift from a base
uses the current tuning table to interpolate in absolute
mode and just adds in normal mode